Issue 3018015: Fixed a couple of issues with store inlining on arm....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3018015: Fixed a couple of issues with store inlining on arm.... (Closed)

Created:
10 years, 5 months ago by Mads Ager (chromium)

Modified:
9 years, 7 months ago

Reviewers:
Vyacheslav Egorov (Chromium)

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Description

Fixed a couple of issues with store inlining on arm. Spill and merge virtual frames explicitly in the deferred code. Account for the fact that the inlined write barrier size depends on the size of the new space masks. Committed: http://code.google.com/p/v8/source/detail?r=5122

Patch Set 1 #

Total comments: 2

Created: 10 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+54 lines, -8 lines)			Patch
M	src/arm/assembler-arm.cc	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	src/arm/codegen-arm.h	View	2 chunks	+5 lines, -1 line	2 comments	Download
M	src/arm/codegen-arm.cc	View	4 chunks	+44 lines, -3 lines	0 comments	Download
M	src/arm/ic-arm.cc	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	src/v8-counters.h	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Vyacheslav Egorov (Chromium)

LGTM http://codereview.chromium.org/3018015/diff/1/4 File src/arm/codegen-arm.h (right): http://codereview.chromium.org/3018015/diff/1/4#newcode594 src/arm/codegen-arm.h:594: static int inlined_write_barrier_size_; Might me reasonable to add ...

10 years, 5 months ago (2010-07-23 08:44:24 UTC) #2

Mads Ager (chromium)

10 years, 5 months ago (2010-07-23 08:47:24 UTC) #3

http://codereview.chromium.org/3018015/diff/1/4
File src/arm/codegen-arm.h (right):

http://codereview.chromium.org/3018015/diff/1/4#newcode594
src/arm/codegen-arm.h:594: static int inlined_write_barrier_size_;
On 2010/07/23 08:44:24, Vyacheslav Egorov wrote:
> Might me reasonable to add name of method used to generate inlined wbs to
> comment 
> 
> Size of inlined write barriers generated by ...
> 
> 

Done.

Expand Messages | Collapse Messages