Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(611)

Side by Side Diff: src/arm/ic-arm.cc

Issue 3018015: Fixed a couple of issues with store inlining on arm.... (Closed) Base URL: http://v8.googlecode.com/svn/branches/bleeding_edge/
Patch Set: Created 10 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright 2006-2008 the V8 project authors. All rights reserved. 1 // Copyright 2006-2008 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 998 matching lines...) Expand 10 before | Expand all | Expand 10 after
1009 ldr_map_instr_address + 3 * Assembler::kInstrSize; 1009 ldr_map_instr_address + 3 * Assembler::kInstrSize;
1010 Instr str_property_instr = Assembler::instr_at(str_property_instr_address); 1010 Instr str_property_instr = Assembler::instr_at(str_property_instr_address);
1011 ASSERT(Assembler::IsStrRegisterImmediate(str_property_instr)); 1011 ASSERT(Assembler::IsStrRegisterImmediate(str_property_instr));
1012 str_property_instr = Assembler::SetStrRegisterImmediateOffset( 1012 str_property_instr = Assembler::SetStrRegisterImmediateOffset(
1013 str_property_instr, offset - kHeapObjectTag); 1013 str_property_instr, offset - kHeapObjectTag);
1014 Assembler::instr_at_put(str_property_instr_address, str_property_instr); 1014 Assembler::instr_at_put(str_property_instr_address, str_property_instr);
1015 1015
1016 // Patch the offset in the add instruction that is part of the 1016 // Patch the offset in the add instruction that is part of the
1017 // write barrier. 1017 // write barrier.
1018 Address add_offset_instr_address = 1018 Address add_offset_instr_address =
1019 str_property_instr_address + 4 * Assembler::kInstrSize; 1019 str_property_instr_address + Assembler::kInstrSize;
1020 Instr add_offset_instr = Assembler::instr_at(add_offset_instr_address); 1020 Instr add_offset_instr = Assembler::instr_at(add_offset_instr_address);
1021 ASSERT(Assembler::IsAddRegisterImmediate(add_offset_instr)); 1021 ASSERT(Assembler::IsAddRegisterImmediate(add_offset_instr));
1022 add_offset_instr = Assembler::SetAddRegisterImmediateOffset( 1022 add_offset_instr = Assembler::SetAddRegisterImmediateOffset(
1023 add_offset_instr, offset - kHeapObjectTag); 1023 add_offset_instr, offset - kHeapObjectTag);
1024 Assembler::instr_at_put(add_offset_instr_address, add_offset_instr); 1024 Assembler::instr_at_put(add_offset_instr_address, add_offset_instr);
1025 1025
1026 // Indicate that code has changed. 1026 // Indicate that code has changed.
1027 CPU::FlushICache(str_property_instr_address, 5 * Assembler::kInstrSize); 1027 CPU::FlushICache(str_property_instr_address, 2 * Assembler::kInstrSize);
1028 } 1028 }
1029 1029
1030 // Patch the map check. 1030 // Patch the map check.
1031 Assembler::set_target_address_at(ldr_map_instr_address, 1031 Assembler::set_target_address_at(ldr_map_instr_address,
1032 reinterpret_cast<Address>(map)); 1032 reinterpret_cast<Address>(map));
1033 1033
1034 return true; 1034 return true;
1035 } 1035 }
1036 1036
1037 1037
(...skipping 1211 matching lines...) Expand 10 before | Expand all | Expand 10 after
2249 GenerateMiss(masm); 2249 GenerateMiss(masm);
2250 } 2250 }
2251 2251
2252 2252
2253 #undef __ 2253 #undef __
2254 2254
2255 2255
2256 } } // namespace v8::internal 2256 } } // namespace v8::internal
2257 2257
2258 #endif // V8_TARGET_ARCH_ARM 2258 #endif // V8_TARGET_ARCH_ARM
OLDNEW
« src/arm/codegen-arm.h ('K') | « src/arm/codegen-arm.cc ('k') | src/v8-counters.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698