Issue 3015007: sync-webkit-git: exit with an error code on failure

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3015007: sync-webkit-git: exit with an error code on failure (Closed)

Created:
10 years, 5 months ago by Evan Martin

Modified:
9 years, 7 months ago

Reviewers:
tony

CC:
chromium-reviews, pam+watch_chromium.org

Base URL:
http://src.chromium.org/git/chromium.git

Visibility:
Public.

Description

sync-webkit-git: exit with an error code on failure Useful when running it in combination with other programs. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=52923

Patch Set 1 #

Total comments: 1

Created: 10 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -4 lines)			Patch
	M	tools/sync-webkit-git.py	View		2 chunks	+4 lines, -4 lines	1 comment	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

tony

10 years, 5 months ago (2010-07-17 01:26:53 UTC) #2

LG

http://codereview.chromium.org/3015007/diff/1/2
File tools/sync-webkit-git.py (right):

http://codereview.chromium.org/3015007/diff/1/2#newcode134
tools/sync-webkit-git.py:134: print "Already on correct revision."
Nit: Specify a return 0 at the end of the function.

Expand Messages | Collapse Messages