sync-webkit-git: exit with an error code on failure

tools/sync-webkit-git.py

Index: tools/sync-webkit-git.py
diff --git a/tools/sync-webkit-git.py b/tools/sync-webkit-git.py
index 4b993575e28fcbfcb9f6834217ef38ebdcc362f3..0f695212b984c61f483b0ea0e1a953eefdebca43 100755
--- a/tools/sync-webkit-git.py
+++ b/tools/sync-webkit-git.py
@@ -105,7 +105,7 @@ def UpdateCurrentCheckoutIfAppropriate():
     print "has some other branch ('%s') checked out." % branch
     print "Run 'git checkout gclient' under third_party/WebKit if you want"
     print "to switch it to the version requested by DEPS."
-    return
+    return 1
 
   if subprocess.call(['git', 'diff-index', '--exit-code', '--shortstat',
                       'HEAD']):
@@ -122,16 +122,16 @@ def main():
 
     print "See http://code.google.com/p/chromium/wiki/UsingWebKitGit for"
     print "setup instructions."
-    return
+    return 1
 
   webkit_rev = GetWebKitRev()
   print 'Desired revision: r%s.' % webkit_rev
   os.chdir('third_party/WebKit')
   changed = UpdateGClientBranch(webkit_rev)
   if changed:
-    UpdateCurrentCheckoutIfAppropriate()
+    return UpdateCurrentCheckoutIfAppropriate()
   else:
     print "Already on correct revision."

[tony, 2010/07/17 01:26:54]

Nit: Specify a return 0 at the end of the function.

 
 if __name__ == '__main__':
-  main()
+  sys.exit(main())