Issue 3007008: Cleanup: Break another common->app dependency.

Issue 3007008: Cleanup: Break another common->app dependency. (Closed)

Created:
10 years, 5 months ago by Lei Zhang

Modified:
9 years, 7 months ago

Reviewers:
M-A Ruel

CC:
chromium-reviews, ncarter (slow), Paul Godavari, John Grabowski, idana, Raghu Simha, amit, ben+cc_chromium.org, brettw-cc_chromium.org, Aaron Boodman, pam+watch_chromium.org, Paweł Hajdan Jr., darin-cc_chromium.org, Erik does not do reviews, tim (not reviewing)

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Cleanup: Break another common->app dependency. BUG=46666 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=53113

Patch Set 1 #

Total comments: 3

Patch Set 2 : minor fix #

Created: 10 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+95 lines, -179 lines)			Patch
M	chrome/app/chrome_dll_main.cc	View	1	4 chunks	+3 lines, -3 lines	0 comments	Download
D	chrome/app/chrome_version_info.h	View	1	1 chunk	+0 lines, -18 lines	0 comments	Download
D	chrome/app/chrome_version_info.cc	View	1	1 chunk	+0 lines, -52 lines	0 comments	Download
D	chrome/app/chrome_version_info_posix.h.version	View	1	1 chunk	+0 lines, -26 lines	0 comments	Download
M	chrome/browser/automation/automation_provider.cc	View	1	3 chunks	+2 lines, -3 lines	0 comments	Download
M	chrome/browser/browser_about_handler.cc	View	1	3 chunks	+2 lines, -3 lines	0 comments	Download
M	chrome/browser/bug_report_util.cc	View	1	2 chunks	+2 lines, -3 lines	0 comments	Download
M	chrome/browser/diagnostics/recon_diagnostics.cc	View	1	3 chunks	+5 lines, -3 lines	0 comments	Download
M	chrome/browser/dom_ui/net_internals_ui.cc	View	1	4 chunks	+3 lines, -2 lines	0 comments	Download
M	chrome/browser/extensions/extension_updater.cc	View	1	4 chunks	+3 lines, -3 lines	0 comments	Download
M	chrome/browser/gtk/about_chrome_dialog.cc	View	1	4 chunks	+6 lines, -4 lines	0 comments	Download
M	chrome/browser/memory_details_mac.cc	View	1	3 chunks	+2 lines, -3 lines	0 comments	Download
M	chrome/browser/memory_details_win.cc	View	1	3 chunks	+3 lines, -3 lines	0 comments	Download
M	chrome/browser/metrics/metrics_log.cc	View	1	3 chunks	+7 lines, -4 lines	0 comments	Download
M	chrome/browser/safe_browsing/protocol_manager.cc	View	1	2 chunks	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/sync/glue/sync_backend_host.cc	View	1	3 chunks	+5 lines, -3 lines	0 comments	Download
M	chrome/browser/upgrade_detector.cc	View	1	3 chunks	+4 lines, -2 lines	0 comments	Download
M	chrome/browser/views/about_chrome_view.cc	View	1	2 chunks	+6 lines, -3 lines	0 comments	Download
M	chrome/browser/views/bug_report_view.cc	View	1	6 chunks	+7 lines, -5 lines	0 comments	Download
M	chrome/chrome_exe.gypi	View	1	3 chunks	+4 lines, -4 lines	0 comments	Download
A +	chrome/common/chrome_version_info.h	View	1	1 chunk	+5 lines, -5 lines	0 comments	Download
A +	chrome/common/chrome_version_info.cc	View	1	3 chunks	+4 lines, -4 lines	0 comments	Download
A +	chrome/common/chrome_version_info_posix.h.version	View		2 chunks	+3 lines, -3 lines	0 comments	Download
M	chrome/common/extensions/extension.cc	View	1	2 chunks	+2 lines, -2 lines	0 comments	Download
M	chrome/renderer/renderer_glue.cc	View	1	5 chunks	+6 lines, -7 lines	0 comments	Download
M	chrome/test/automation/automation_proxy.cc	View	1	3 chunks	+5 lines, -4 lines	0 comments	Download
M	chrome/test/reliability/page_load_test.cc	View	1	2 chunks	+2 lines, -2 lines	0 comments	Download
M	chrome_frame/metrics_service.cc	View	1	3 chunks	+2 lines, -3 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

M-A Ruel

lgtm http://codereview.chromium.org/3007008/diff/1/17 File chrome/browser/sync/glue/sync_backend_host.cc (right): http://codereview.chromium.org/3007008/diff/1/17#newcode11 chrome/browser/sync/glue/sync_backend_host.cc:11: #include "build/build_config.h" this one is special and it ...

10 years, 5 months ago (2010-07-20 21:00:48 UTC) #2

Lei Zhang

http://codereview.chromium.org/3007008/diff/1/17 File chrome/browser/sync/glue/sync_backend_host.cc (right): http://codereview.chromium.org/3007008/diff/1/17#newcode11 chrome/browser/sync/glue/sync_backend_host.cc:11: #include "build/build_config.h" On 2010/07/20 21:00:49, Marc-Antoine Ruel wrote: > ...

10 years, 5 months ago (2010-07-20 21:03:51 UTC) #3

M-A Ruel

10 years, 5 months ago (2010-07-20 21:05:51 UTC) #4

http://codereview.chromium.org/3007008/diff/1/17
File chrome/browser/sync/glue/sync_backend_host.cc (right):

http://codereview.chromium.org/3007008/diff/1/17#newcode11
chrome/browser/sync/glue/sync_backend_host.cc:11: #include
"build/build_config.h"
On 2010/07/20 21:03:51, Lei Zhang wrote:
> On 2010/07/20 21:00:49, Marc-Antoine Ruel wrote:
> > this one is special and it is preferred to keep it at the top.
> 
> Sure, fixed - but there's no #if define above this and all the headers that
> needs it should've included it already.

Yeah, I don't really mind either way.

Expand Messages | Collapse Messages