Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(86)

Unified Diff: chrome/app/chrome_version_info.cc

Issue 3007008: Cleanup: Break another common->app dependency. (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: minor fix Created 10 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/app/chrome_version_info.h ('k') | chrome/app/chrome_version_info_posix.h.version » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/app/chrome_version_info.cc
===================================================================
--- chrome/app/chrome_version_info.cc (revision 53088)
+++ chrome/app/chrome_version_info.cc (working copy)
@@ -1,52 +0,0 @@
-// Copyright (c) 2010 The Chromium Authors. All rights reserved.
-// Use of this source code is governed by a BSD-style license that can be
-// found in the LICENSE file.
-
-#include "chrome/app/chrome_version_info.h"
-
-#include "base/basictypes.h"
-#include "base/file_version_info.h"
-#include "build/build_config.h"
-
-#if defined(OS_POSIX) && !defined(OS_MACOSX)
-#include "chrome/app/chrome_version_info_posix.h"
-
-// Posix files don't have per-file version information, so we get chrome
-// version information from chrome_version_info_posix.h, a generated header.
-class ChromeVersionInfoPosix : public FileVersionInfo {
- public:
- ChromeVersionInfoPosix() {}
-
- virtual std::wstring company_name() { return COMPANY_NAME; }
- virtual std::wstring company_short_name() { return COMPANY_SHORT_NAME; }
- virtual std::wstring product_name() { return PRODUCT_NAME; }
- virtual std::wstring product_short_name() { return PRODUCT_SHORT_NAME; }
- virtual std::wstring internal_name() { return INTERNAL_NAME; }
- virtual std::wstring product_version() { return PRODUCT_VERSION; }
- virtual std::wstring private_build() { return PRIVATE_BUILD; }
- virtual std::wstring special_build() { return SPECIAL_BUILD; }
- virtual std::wstring comments() { return COMMENTS; }
- virtual std::wstring original_filename() { return ORIGINAL_FILENAME; }
- virtual std::wstring file_description() { return FILE_DESCRIPTION; }
- virtual std::wstring file_version() { return FILE_VERSION; }
- virtual std::wstring legal_copyright() { return LEGAL_COPYRIGHT; }
- virtual std::wstring legal_trademarks() { return LEGAL_TRADEMARKS; }
- virtual std::wstring last_change() { return LAST_CHANGE; }
- virtual bool is_official_build() { return OFFICIAL_BUILD; }
-
- private:
- DISALLOW_COPY_AND_ASSIGN(ChromeVersionInfoPosix);
-};
-#endif
-
-namespace chrome_app {
-
-FileVersionInfo* GetChromeVersionInfo() {
-#if defined(OS_WIN) || defined(OS_MACOSX)
- return FileVersionInfo::CreateFileVersionInfoForCurrentModule();
-#elif defined(OS_POSIX)
- return new ChromeVersionInfoPosix();
-#endif
-}
-
-} // namespace chrome_app
« no previous file with comments | « chrome/app/chrome_version_info.h ('k') | chrome/app/chrome_version_info_posix.h.version » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698