chrome/browser/automation/automation_provider.cc - Issue 3007008: Cleanup: Break another common->app dependency.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/automation/automation_provider.cc

Issue 3007008: Cleanup: Break another common->app dependency. (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/

Patch Set: minor fix Created 10 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/automation/automation_provider.cc

===================================================================

--- chrome/browser/automation/automation_provider.cc (revision 53088)

+++ chrome/browser/automation/automation_provider.cc (working copy)

@@ -26,7 +26,6 @@

#include "base/values.h"

#include "base/waitable_event.h"

#include "chrome/app/chrome_dll_resource.h"

-#include "chrome/app/chrome_version_info.h"

#include "chrome/browser/app_modal_dialog.h"

#include "chrome/browser/app_modal_dialog_queue.h"

#include "chrome/browser/autofill/autofill_manager.h"

@@ -83,6 +82,7 @@

#include "chrome/common/automation_constants.h"

#include "chrome/common/chrome_constants.h"

#include "chrome/common/chrome_paths.h"

+#include "chrome/common/chrome_version_info.h"

#include "chrome/common/extensions/extension.h"

#include "chrome/common/json_value_serializer.h"

#include "chrome/common/net/url_request_context_getter.h"

@@ -194,8 +194,7 @@

automation_resource_message_filter_,

g_browser_process->io_thread()->message_loop(),

true, g_browser_process->shutdown_event()));

- scoped_ptr<FileVersionInfo> version_info(

- chrome_app::GetChromeVersionInfo());

+ scoped_ptr<FileVersionInfo> version_info(chrome::GetChromeVersionInfo());

std::string version_string;

if (version_info != NULL) {

version_string = WideToASCII(version_info->file_version());