Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(407)

Issue 2934004: Try to cut down Browser/TabContents header dependencies. (Closed)

Created:
10 years, 5 months ago by Elliot Glaysher
Modified:
9 years, 7 months ago
CC:
chromium-reviews, ben+cc_chromium.org, Erik does not do reviews, Paweł Hajdan Jr., Aaron Boodman, pam+watch_chromium.org, brettw-cc_chromium.org, darin-cc_chromium.org
Base URL:
http://src.chromium.org/git/chromium.git
Visibility:
Public.

Description

Try to cut down Browser/TabContents header dependencies. - Forward declare printing::PrintViewManager in TabContents - tab_contents.h shouldn't depend on autocomplete_edit.h - Pull logging out of Browser through PageTransitionTypes BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=51995

Patch Set 1 #

Patch Set 2 : remove more headers #

Patch Set 3 : URLPattern #

Patch Set 4 : WebPreferences #

Patch Set 5 : fix unit tests compile #

Unified diffs Side-by-side diffs Delta from patch set Stats (+42 lines, -23 lines) Patch
M chrome/browser/automation/automation_provider.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/browser.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/extensions/image_loading_tracker_unittest.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/history/history_types.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/history/visit_database.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/omnibox_search_hint.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/renderer_host/test/test_render_view_host.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/tab_contents/render_view_context_menu.cc View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/tab_contents/tab_contents.h View 1 2 3 7 chunks +7 lines, -7 lines 0 comments Download
M chrome/browser/tab_contents/tab_contents.cc View 1 2 3 6 chunks +9 lines, -4 lines 0 comments Download
M chrome/browser/tab_contents/test_tab_contents.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/toolbar_model.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/common/extensions/extension.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/extensions/extension.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/common/page_transition_types.h View 2 chunks +1 line, -10 lines 0 comments Download
M chrome/common/page_transition_types.cc View 1 chunk +14 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Elliot Glaysher
10 years, 5 months ago (2010-07-09 00:46:11 UTC) #1
Ben Goodger (Google)
10 years, 5 months ago (2010-07-09 19:34:17 UTC) #2
LGTM. Awesomeness.

Powered by Google App Engine
This is Rietveld 408576698