Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(51)

Side by Side Diff: chrome/common/page_transition_types.cc

Issue 2934004: Try to cut down Browser/TabContents header dependencies. (Closed) Base URL: http://src.chromium.org/git/chromium.git
Patch Set: fix unit tests compile Created 10 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « chrome/common/page_transition_types.h ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2010 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/common/page_transition_types.h" 5 #include "chrome/common/page_transition_types.h"
6 6
7 #include "base/logging.h"
8
9 // static
10 PageTransition::Type PageTransition::FromInt(int32 type) {
11 if (!ValidType(type)) {
12 NOTREACHED() << "Invalid transition type " << type;
13
14 // Return a safe default so we don't have corrupt data in release mode.
15 return LINK;
16 }
17 return static_cast<Type>(type);
18 }
19
20 // static
7 const char* PageTransition::CoreTransitionString(Type type) { 21 const char* PageTransition::CoreTransitionString(Type type) {
8 switch (type & PageTransition::CORE_MASK) { 22 switch (type & PageTransition::CORE_MASK) {
9 case 0: return "link"; 23 case 0: return "link";
10 case 1: return "typed"; 24 case 1: return "typed";
11 case 2: return "auto_bookmark"; 25 case 2: return "auto_bookmark";
12 case 3: return "auto_subframe"; 26 case 3: return "auto_subframe";
13 case 4: return "manual_subframe"; 27 case 4: return "manual_subframe";
14 case 5: return "generated"; 28 case 5: return "generated";
15 case 6: return "start_page"; 29 case 6: return "start_page";
16 case 7: return "form_submit"; 30 case 7: return "form_submit";
17 case 8: return "reload"; 31 case 8: return "reload";
18 case 9: return "keyword"; 32 case 9: return "keyword";
19 case 10: return "keyword_generated"; 33 case 10: return "keyword_generated";
20 } 34 }
21 return NULL; 35 return NULL;
22 } 36 }
OLDNEW
« no previous file with comments | « chrome/common/page_transition_types.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698