Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5045)

Unified Diff: chrome/common/page_transition_types.h

Issue 2934004: Try to cut down Browser/TabContents header dependencies. (Closed) Base URL: http://src.chromium.org/git/chromium.git
Patch Set: fix unit tests compile Created 10 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/common/extensions/extension.cc ('k') | chrome/common/page_transition_types.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/common/page_transition_types.h
diff --git a/chrome/common/page_transition_types.h b/chrome/common/page_transition_types.h
index bb460066ca70a6bcb1ebbb6bc23eee7226fedbee..592fc291533a2547ae3d5b915edc293c229e63e5 100644
--- a/chrome/common/page_transition_types.h
+++ b/chrome/common/page_transition_types.h
@@ -6,7 +6,6 @@
#define CHROME_COMMON_PAGE_TRANSITION_TYPES_H__
#include "base/basictypes.h"
-#include "base/logging.h"
// This class is for scoping only.
class PageTransition {
@@ -131,15 +130,7 @@ class PageTransition {
return (t <= LAST_CORE);
}
- static Type FromInt(int32 type) {
- if (!ValidType(type)) {
- NOTREACHED() << "Invalid transition type " << type;
-
- // Return a safe default so we don't have corrupt data in release mode.
- return LINK;
- }
- return static_cast<Type>(type);
- }
+ static Type FromInt(int32 type);
// Returns true if the given transition is a top-level frame transition, or
// false if the transition was for a subframe.
« no previous file with comments | « chrome/common/extensions/extension.cc ('k') | chrome/common/page_transition_types.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698