Issue 2928009: Fix GenerateNegativeLookup to work with non-symbols as a dictionary key.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2928009: Fix GenerateNegativeLookup to work with non-symbols as a dictionary key. (Closed)

Created:
10 years, 5 months ago by SeRya

Modified:
9 years, 7 months ago

Reviewers:
Mads Ager (chromium)

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Fix GenerateNegativeLookup to work with non-symbols as a dictionary key. Committed: http://code.google.com/p/v8/source/detail?r=5071

Created: 10 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+34 lines, -0 lines)			Patch
M	src/arm/stub-cache-arm.cc	View	1	1 chunk	+7 lines, -0 lines	0 comments	Download
M	src/ia32/stub-cache-ia32.cc	View	1	1 chunk	+6 lines, -0 lines	0 comments	Download
M	src/x64/stub-cache-x64.cc	View	1	1 chunk	+6 lines, -0 lines	0 comments	Download
M	test/mjsunit/call-stub.js	View	1	1 chunk	+15 lines, -0 lines	0 comments	Download

Total messages: 3 (0 generated)

SeRya

http://codereview.chromium.org/2801018 was written supposing dictionary can only contain symbols as keys. Vlad pointed me that ...

10 years, 5 months ago (2010-07-14 14:49:28 UTC) #1

Mads Ager (chromium)

LGTM, we need to push this to the 2.2 branch when comitted.

10 years, 5 months ago (2010-07-15 06:00:36 UTC) #2

Fixed LINT error.