Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9)

Side by Side Diff: src/x64/stub-cache-x64.cc

Issue 2928009: Fix GenerateNegativeLookup to work with non-symbols as a dictionary key. (Closed) Base URL: http://v8.googlecode.com/svn/branches/bleeding_edge/
Patch Set: '' Created 10 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/ia32/stub-cache-ia32.cc ('k') | test/mjsunit/call-stub.js » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2010 the V8 project authors. All rights reserved. 1 // Copyright 2010 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 146 matching lines...) Expand 10 before | Expand all | Expand 10 after
157 __ movq(entity_name, Operand(properties, index, times_pointer_size, 157 __ movq(entity_name, Operand(properties, index, times_pointer_size,
158 kElementsStartOffset - kHeapObjectTag)); 158 kElementsStartOffset - kHeapObjectTag));
159 __ Cmp(entity_name, Factory::undefined_value()); 159 __ Cmp(entity_name, Factory::undefined_value());
160 // __ jmp(miss_label); 160 // __ jmp(miss_label);
161 if (i != kProbes - 1) { 161 if (i != kProbes - 1) {
162 __ j(equal, &done); 162 __ j(equal, &done);
163 163
164 // Stop if found the property. 164 // Stop if found the property.
165 __ Cmp(entity_name, Handle<String>(name)); 165 __ Cmp(entity_name, Handle<String>(name));
166 __ j(equal, miss_label); 166 __ j(equal, miss_label);
167
168 // Check if the entry name is not a symbol.
169 __ movq(entity_name, FieldOperand(entity_name, HeapObject::kMapOffset));
170 __ testb(FieldOperand(entity_name, Map::kInstanceTypeOffset),
171 Immediate(kIsSymbolMask));
172 __ j(zero, miss_label);
167 } else { 173 } else {
168 // Give up probing if still not found the undefined value. 174 // Give up probing if still not found the undefined value.
169 __ j(not_equal, miss_label); 175 __ j(not_equal, miss_label);
170 } 176 }
171 } 177 }
172 178
173 __ bind(&done); 179 __ bind(&done);
174 __ DecrementCounter(&Counters::negative_lookups_miss, 1); 180 __ DecrementCounter(&Counters::negative_lookups_miss, 1);
175 } 181 }
176 182
(...skipping 2368 matching lines...) Expand 10 before | Expand all | Expand 10 after
2545 // Return the generated code. 2551 // Return the generated code.
2546 return GetCode(); 2552 return GetCode();
2547 } 2553 }
2548 2554
2549 2555
2550 #undef __ 2556 #undef __
2551 2557
2552 } } // namespace v8::internal 2558 } } // namespace v8::internal
2553 2559
2554 #endif // V8_TARGET_ARCH_X64 2560 #endif // V8_TARGET_ARCH_X64
OLDNEW
« no previous file with comments | « src/ia32/stub-cache-ia32.cc ('k') | test/mjsunit/call-stub.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698