Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(109)

Side by Side Diff: src/arm/stub-cache-arm.cc

Issue 2928009: Fix GenerateNegativeLookup to work with non-symbols as a dictionary key. (Closed) Base URL: http://v8.googlecode.com/svn/branches/bleeding_edge/
Patch Set: '' Created 10 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | src/ia32/stub-cache-ia32.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2006-2009 the V8 project authors. All rights reserved. 1 // Copyright 2006-2009 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 158 matching lines...) Expand 10 before | Expand all | Expand 10 after
169 ASSERT(!tmp.is(entity_name)); 169 ASSERT(!tmp.is(entity_name));
170 __ LoadRoot(tmp, Heap::kUndefinedValueRootIndex); 170 __ LoadRoot(tmp, Heap::kUndefinedValueRootIndex);
171 __ cmp(entity_name, tmp); 171 __ cmp(entity_name, tmp);
172 if (i != kProbes - 1) { 172 if (i != kProbes - 1) {
173 __ b(eq, &done); 173 __ b(eq, &done);
174 174
175 // Stop if found the property. 175 // Stop if found the property.
176 __ cmp(entity_name, Operand(Handle<String>(name))); 176 __ cmp(entity_name, Operand(Handle<String>(name)));
177 __ b(eq, miss_label); 177 __ b(eq, miss_label);
178 178
179 // Check if the entry name is not a symbol.
180 __ ldr(entity_name, FieldMemOperand(entity_name, HeapObject::kMapOffset));
181 __ ldrb(entity_name,
182 FieldMemOperand(entity_name, Map::kInstanceTypeOffset));
183 __ tst(entity_name, Operand(kIsSymbolMask));
184 __ b(eq, miss_label);
185
179 // Restore the properties. 186 // Restore the properties.
180 __ ldr(properties, 187 __ ldr(properties,
181 FieldMemOperand(receiver, JSObject::kPropertiesOffset)); 188 FieldMemOperand(receiver, JSObject::kPropertiesOffset));
182 } else { 189 } else {
183 // Give up probing if still not found the undefined value. 190 // Give up probing if still not found the undefined value.
184 __ b(ne, miss_label); 191 __ b(ne, miss_label);
185 } 192 }
186 } 193 }
187 __ bind(&done); 194 __ bind(&done);
188 __ DecrementCounter(&Counters::negative_lookups_miss, 1, scratch0, scratch1); 195 __ DecrementCounter(&Counters::negative_lookups_miss, 1, scratch0, scratch1);
(...skipping 2182 matching lines...) Expand 10 before | Expand all | Expand 10 after
2371 // Return the generated code. 2378 // Return the generated code.
2372 return GetCode(); 2379 return GetCode();
2373 } 2380 }
2374 2381
2375 2382
2376 #undef __ 2383 #undef __
2377 2384
2378 } } // namespace v8::internal 2385 } } // namespace v8::internal
2379 2386
2380 #endif // V8_TARGET_ARCH_ARM 2387 #endif // V8_TARGET_ARCH_ARM
OLDNEW
« no previous file with comments | « no previous file | src/ia32/stub-cache-ia32.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698