[chromeos]Allow input method can get tab key when inputting in omnibox.

[chromeos]Allow input method can get tab key when inputting in omnibox.

BUG=http://crosbug.com/4552
TEST=See the bug report.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=52287

[Jay Civelli, 2010-07-12 22:12:48]

I am confused. Doesn't that break tab traversal? Meaning pressing tab from the
location bar will always trigger a tab.
Shouldn't tab be overriden only when the IME popup is showing?

[James Su, 2010-07-12 22:43:16]

On 2010/07/12 22:12:48, Jay Civelli wrote:
> I am confused. Doesn't that break tab traversal? Meaning pressing tab from the
> location bar will always trigger a tab.
> Shouldn't tab be overriden only when the IME popup is showing?

I was afraid of it as well. But I just tested this code today and the tab
traversal worked as normal. I don't know why :) I'd very appreciate if somebody
can tell me the reasion.

You may have a try.

[James Su, 2010-07-12 22:44:18]

On 2010/07/12 22:43:16, James Su wrote:
> On 2010/07/12 22:12:48, Jay Civelli wrote:
> > I am confused. Doesn't that break tab traversal? Meaning pressing tab from
the
> > location bar will always trigger a tab.
> > Shouldn't tab be overriden only when the IME popup is showing?
> 
> I was afraid of it as well. But I just tested this code today and the tab
> traversal worked as normal. I don't know why :) I'd very appreciate if
somebody
> can tell me the reasion.
> 
> You may have a try.

And, there is no way for us to know when the input method shows the popup menu.

[James Su, 2010-07-13 07:17:16]

Just debugged it. Turns out that it works because GtkWindow handles "move-focus"
event emitted by omnibox.

On 2010/07/12 22:44:18, James Su wrote:
> On 2010/07/12 22:43:16, James Su wrote:
> > On 2010/07/12 22:12:48, Jay Civelli wrote:
> > > I am confused. Doesn't that break tab traversal? Meaning pressing tab from
> the
> > > location bar will always trigger a tab.
> > > Shouldn't tab be overriden only when the IME popup is showing?
> > 
> > I was afraid of it as well. But I just tested this code today and the tab
> > traversal worked as normal. I don't know why :) I'd very appreciate if
> somebody
> > can tell me the reasion.
> > 
> > You may have a try.
> 
> And, there is no way for us to know when the input method shows the popup
menu.

[satorux1, 2010-07-13 07:30:46]

LGTM.

Glad to know that you now understand why it works.

On 2010/07/13 07:17:16, James Su wrote:
> Just debugged it. Turns out that it works because GtkWindow handles
"move-focus"
> event emitted by omnibox.
> 
> On 2010/07/12 22:44:18, James Su wrote:
> > On 2010/07/12 22:43:16, James Su wrote:
> > > On 2010/07/12 22:12:48, Jay Civelli wrote:
> > > > I am confused. Doesn't that break tab traversal? Meaning pressing tab
from
> > the
> > > > location bar will always trigger a tab.
> > > > Shouldn't tab be overriden only when the IME popup is showing?
> > > 
> > > I was afraid of it as well. But I just tested this code today and the tab
> > > traversal worked as normal. I don't know why :) I'd very appreciate if
> > somebody
> > > can tell me the reasion.
> > > 
> > > You may have a try.
> > 
> > And, there is no way for us to know when the input method shows the popup
> menu.