Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4268)

Unified Diff: chrome/browser/views/location_bar/location_bar_view.cc

Issue 2925009: [chromeos]Allow input method can get tab key when inputting in omnibox. (Closed) Base URL: http://src.chromium.org/git/chromium.git
Patch Set: Created 10 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/views/location_bar/location_bar_view.cc
diff --git a/chrome/browser/views/location_bar/location_bar_view.cc b/chrome/browser/views/location_bar/location_bar_view.cc
index 781d082793cfd8fa5d9262bc6f7c78b3b1a080af..8ed874da7d35c6843905815d3962f86dea4c0130 100644
--- a/chrome/browser/views/location_bar/location_bar_view.cc
+++ b/chrome/browser/views/location_bar/location_bar_view.cc
@@ -885,9 +885,10 @@ bool LocationBarView::SkipDefaultKeyEventProcessing(const views::KeyEvent& e) {
// TODO(jcampan): We need to refactor the code of
// AutocompleteEditViewWin::SkipDefaultKeyEventProcessing into this class so
// it can be shared between Windows and Linux.
- // For now, we just override back-space as it is the accelerator for back
- // navigation.
- if (e.GetKeyCode() == base::VKEY_BACK)
+ // For now, we just override back-space and tab keys, as back-space is the
+ // accelerator for back navigation and tab key is used by some input methods.
+ if (e.GetKeyCode() == base::VKEY_BACK ||
+ views::FocusManager::IsTabTraversalKeyEvent(e))
return true;
return false;
#endif
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698