Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(146)

Side by Side Diff: chrome/browser/views/location_bar/location_bar_view.cc

Issue 2925009: [chromeos]Allow input method can get tab key when inputting in omnibox. (Closed) Base URL: http://src.chromium.org/git/chromium.git
Patch Set: Created 10 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2010 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/views/location_bar/location_bar_view.h" 5 #include "chrome/browser/views/location_bar/location_bar_view.h"
6 6
7 #if defined(OS_LINUX) 7 #if defined(OS_LINUX)
8 #include <gtk/gtk.h> 8 #include <gtk/gtk.h>
9 #endif 9 #endif
10 10
(...skipping 867 matching lines...) Expand 10 before | Expand all | Expand 10 after
878 // We want to receive tab key events when the hint is showing. 878 // We want to receive tab key events when the hint is showing.
879 return true; 879 return true;
880 } 880 }
881 881
882 #if defined(OS_WIN) 882 #if defined(OS_WIN)
883 return location_entry_->SkipDefaultKeyEventProcessing(e); 883 return location_entry_->SkipDefaultKeyEventProcessing(e);
884 #else 884 #else
885 // TODO(jcampan): We need to refactor the code of 885 // TODO(jcampan): We need to refactor the code of
886 // AutocompleteEditViewWin::SkipDefaultKeyEventProcessing into this class so 886 // AutocompleteEditViewWin::SkipDefaultKeyEventProcessing into this class so
887 // it can be shared between Windows and Linux. 887 // it can be shared between Windows and Linux.
888 // For now, we just override back-space as it is the accelerator for back 888 // For now, we just override back-space and tab keys, as back-space is the
889 // navigation. 889 // accelerator for back navigation and tab key is used by some input methods.
890 if (e.GetKeyCode() == base::VKEY_BACK) 890 if (e.GetKeyCode() == base::VKEY_BACK ||
891 views::FocusManager::IsTabTraversalKeyEvent(e))
891 return true; 892 return true;
892 return false; 893 return false;
893 #endif 894 #endif
894 } 895 }
895 896
896 bool LocationBarView::GetAccessibleRole(AccessibilityTypes::Role* role) { 897 bool LocationBarView::GetAccessibleRole(AccessibilityTypes::Role* role) {
897 DCHECK(role); 898 DCHECK(role);
898 899
899 *role = AccessibilityTypes::ROLE_GROUPING; 900 *role = AccessibilityTypes::ROLE_GROUPING;
900 return true; 901 return true;
(...skipping 136 matching lines...) Expand 10 before | Expand all | Expand 10 after
1037 page_action_views_[i]->image_view()->ExecuteAction(kLeftMouseButton, 1038 page_action_views_[i]->image_view()->ExecuteAction(kLeftMouseButton,
1038 false); // inspect_with_devtools 1039 false); // inspect_with_devtools
1039 return; 1040 return;
1040 } 1041 }
1041 ++current; 1042 ++current;
1042 } 1043 }
1043 } 1044 }
1044 1045
1045 NOTREACHED(); 1046 NOTREACHED();
1046 } 1047 }
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698