Disallow syncing of extensions with third-party update URLs or plugins.

Disallow syncing of extensions with third-party update URLs or plugins.

BUG=49346, 46516
TEST=new unit tests, manual

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=53102

[akalin, 2010-07-19 21:58:35]

+tim for review

[tim (not reviewing), 2010-07-19 22:07:43]

LGTM

[akalin, 2010-07-20 00:57:42]

Fixed to compare against *correct* gallery URL.

Submitting as soon as trybots pass.

On 2010/07/19 22:07:43, timsteele wrote:
> LGTM

[akalin, 2010-07-20 01:27:26]

Tightened check per inferno's comments.

+inferno for sec review, +asargent for extensions stuff.  Tim, please take
another look, too.

On 2010/07/20 00:57:42, akalin wrote:
> Fixed to compare against *correct* gallery URL.
> 
> Submitting as soon as trybots pass.
> 
> On 2010/07/19 22:07:43, timsteele wrote:
> > LGTM

[akalin, 2010-07-20 01:27:56]

+inferno, asargent for review

[inferno, 2010-07-20 01:32:56]

LGTM.

On 2010/07/20 01:27:56, akalin wrote:
> +inferno, asargent for review

[akalin, 2010-07-20 17:56:11]

asargent, tim, ping!

On 2010/07/20 01:32:56, inferno wrote:
> LGTM.
> 
> On 2010/07/20 01:27:56, akalin wrote:
> > +inferno, asargent for review

[asargent_no_longer_on_chrome, 2010-07-20 18:08:25]

lgtm. Sorry for the delay, I didn't realize this was a separate codereview from
yesterday's.

[asargent_no_longer_on_chrome, 2010-07-20 18:08:37]

http://codereview.chromium.org/2884025/diff/3002/19001
File chrome/browser/extensions/extension_updater.cc (right):

http://codereview.chromium.org/2884025/diff/3002/19001#newcode240
chrome/browser/extensions/extension_updater.cc:240: update_url =
GURL(extension_urls::kGalleryUpdateHttpUrl);
FYI, we intentionally picked the http one here because extension updating relies
on the keypair used to sign the crx files. If we find we need to switch to
https, we should touch base with the Omaha folks to make sure they can handle
the extra load, and we might consider using https only for the sync case or
something.