Disallow syncing of extensions with third-party update URLs or plugins.

chrome/browser/sync/glue/extension_util.cc

 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/sync/glue/extension_util.h"
 
 #include <sstream>
 
 #include "base/logging.h"
 #include "base/scoped_ptr.h"
 #include "base/version.h"
 #include "chrome/browser/extensions/extensions_service.h"
 #include "chrome/browser/sync/protocol/extension_specifics.pb.h"
 #include "chrome/common/extensions/extension.h"
+#include "chrome/common/extensions/extension_constants.h"
 #include "googleurl/src/gurl.h"
 
 namespace browser_sync {
 
 bool IsExtensionSyncable(const Extension& extension) {
   if (extension.is_theme()) {
     return false;
   }
 
   // TODO(akalin): Add Extensions::is_app().
   if (!extension.GetFullLaunchURL().is_empty()) {
     // We have an app.
     return false;
   }
 
   // TODO(akalin): Figure out if we need to allow some other types.
   if (extension.location() != Extension::INTERNAL) {
     // We have a non-standard location.
     return false;
   }
 
+  // Disallow extensions with non-gallery auto-update URLs for now.
+  //
+  // TODO(akalin): Relax this restriction once we've put in UI to
+  // approve synced extensions.
+  if (!extension.update_url().is_empty() &&
+      (extension.update_url() !=
+       GURL(extension_urls::kGalleryUpdateHttpUrl)) &&
+      (extension.update_url() !=
+       GURL(extension_urls::kGalleryUpdateHttpsUrl))) {
+    return false;
+  }
+
+  // Disallow extensions with native code plugins.
+  //
+  // TODO(akalin): Relax this restriction once we've put in UI to
+  // approve synced extensions.
+  if (!extension.plugins().empty()) {
+    return false;
+  }
+
   return true;
 }
 
 std::string ExtensionSpecificsToString(
     const sync_pb::ExtensionSpecifics& specifics) {
   std::stringstream ss;
   ss << "{ ";
   ss << "id: "                   << specifics.id()                << ", ";
   ss << "version: "              << specifics.version()           << ", ";
   ss << "update_url: "           << specifics.update_url()        << ", ";
@@ skipping 175 matching lines @@
     // |specifics| has a more recent or the same version, so merge it
     // in.
     CopyNonUserProperties(specifics, merged_specifics);
     if (merge_user_properties) {
       CopyUserProperties(specifics, merged_specifics);
     }
   }
 }
 
 }  // namespace browser_sync