Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(731)

Unified Diff: chrome/browser/extensions/extension_updater.cc

Issue 2884025: Disallow syncing of extensions with third-party update URLs or plugins. (Closed)
Patch Set: Tightened check Created 10 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/sync/glue/extension_util.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/extensions/extension_updater.cc
diff --git a/chrome/browser/extensions/extension_updater.cc b/chrome/browser/extensions/extension_updater.cc
index d2186942af719b346641491f46db4ad88ffaaef7..232d9ddd56123e84eaeed776511a650a27217996 100644
--- a/chrome/browser/extensions/extension_updater.cc
+++ b/chrome/browser/extensions/extension_updater.cc
@@ -235,7 +235,9 @@ void ManifestFetchesBuilder::AddExtensionData(
} else if (update_url.is_empty()) {
url_stats_.no_url_count++;
// Fill in default update URL.
- update_url = GURL(extension_urls::kGalleryUpdateURL);
+ //
+ // TODO(akalin): Figure out if we should use the HTTPS version.
+ update_url = GURL(extension_urls::kGalleryUpdateHttpUrl);
asargent_no_longer_on_chrome 2010/07/20 18:08:38 FYI, we intentionally picked the http one here bec
} else {
url_stats_.other_url_count++;
}
« no previous file with comments | « no previous file | chrome/browser/sync/glue/extension_util.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698