Issue 2878056: Put back 53641 - Landing OEM customization CL for Denis...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2878056: Put back 53641 - Landing OEM customization CL for Denis... (Closed)

Created:
10 years, 5 months ago by Dmitry Polukhin

Modified:
9 years, 7 months ago

Reviewers:
Nikita (slow)

CC:
chromium-reviews, brettw-cc_chromium.org, nkostylev+cc_chromium.org, davemoore+watch_chromium.org, ben+cc_chromium.org

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Put back 53641 - Landing OEM customization CL for Denis Original CL http://codereview.chromium.org/3026006 Fixed problems with initial locale change freezing Chrome OS on the device. Added creation of /home/chronos/.oobe_completed flag file. Removed command line switches for testing customization manifests. Added StringFetcher class implementation - URL fetcher that downloads content into std::string. Refactored services customization integration. Removed sample manifests from Chrome repository. They are submitted into Chromium OS repository at chromeos/src/platform/assets/oem_customization. BUG=http://crosbug.com/1888 TEST=Manual. Changes to OEM customization manifests on partner partition, namely the initial locale, time zone, and startup page attributes should change OOBE UX accordingly. Review URL: http://codereview.chromium.org/3064002 TBR= nkostylev@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=53775

Patch Set 1 #

Patch Set 2 : '' #

Created: 10 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+237 lines, -148 lines)			Patch
M	chrome/browser/browser_init.h	View	1 chunk	+0 lines, -7 lines	0 comments	Download
M	chrome/browser/browser_init.cc	View	1 chunk	+0 lines, -13 lines	0 comments	Download
M	chrome/browser/browser_main.cc	View	3 chunks	+0 lines, -37 lines	0 comments	Download
M	chrome/browser/chromeos/login/existing_user_controller.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
A	chrome/browser/chromeos/login/string_fetcher.h	View	1 chunk	+47 lines, -0 lines	0 comments	Download
A	chrome/browser/chromeos/login/string_fetcher.cc	View	1 chunk	+51 lines, -0 lines	0 comments	Download
M	chrome/browser/chromeos/login/wizard_controller.h	View	5 chunks	+14 lines, -1 line	0 comments	Download
M	chrome/browser/chromeos/login/wizard_controller.cc	View	11 chunks	+122 lines, -35 lines	0 comments	Download
D	chrome/browser/chromeos/testdata/services_manifest.json	View	1 chunk	+0 lines, -19 lines	0 comments	Download
D	chrome/browser/chromeos/testdata/startup_manifest.json	View	1 chunk	+0 lines, -23 lines	0 comments	Download
M	chrome/chrome_browser.gypi	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	chrome/common/chrome_switches.h	View	1 chunk	+0 lines, -4 lines	0 comments	Download
M	chrome/common/chrome_switches.cc	View	1 chunk	+0 lines, -8 lines	0 comments	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages

LGTM

Expand Messages | Collapse Messages