Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(397)

Issue 3026006: Fixed problems with initial locale change freezing Chrome OS on the device.... (Closed)

Created:
10 years, 5 months ago by dr
Modified:
9 years, 7 months ago
Reviewers:
Nikita (slow)
CC:
chromium-reviews, brettw-cc_chromium.org, nkostylev+cc_chromium.org, davemoore+watch_chromium.org, ben+cc_chromium.org
Visibility:
Public.

Description

Fixed problems with initial locale change freezing Chrome OS on the device. Added creation of /home/chronos/.oobe_completed flag file. Removed command line switches for testing customization manifests. Added StringFetcher class implementation - URL fetcher that downloads content into std::string. Refactored services customization integration. Removed sample manifests from Chrome repository. They are submitted into Chromium OS repository at chromeos/src/platform/assets/oem_customization. Landed in: http://codereview.chromium.org/2878056 BUG=http://crosbug.com/1888 TEST=Manual. Changes to OEM customization manifests on partner partition, namely the initial locale, time zone, and startup page attributes should change OOBE UX accordingly.

Patch Set 1 #

Total comments: 12
Unified diffs Side-by-side diffs Delta from patch set Stats (+178 lines, -135 lines) Patch
M chrome/browser/browser_init.h View 1 chunk +0 lines, -7 lines 0 comments Download
M chrome/browser/browser_init.cc View 1 chunk +0 lines, -13 lines 0 comments Download
M chrome/browser/browser_main.cc View 3 chunks +0 lines, -37 lines 0 comments Download
A chrome/browser/chromeos/login/string_fetcher.h View 1 chunk +46 lines, -0 lines 2 comments Download
A chrome/browser/chromeos/login/string_fetcher.cc View 1 chunk +44 lines, -0 lines 2 comments Download
M chrome/browser/chromeos/login/wizard_controller.h View 3 chunks +7 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/login/wizard_controller.cc View 6 chunks +79 lines, -24 lines 8 comments Download
D chrome/browser/chromeos/testdata/services_manifest.json View 1 chunk +0 lines, -19 lines 0 comments Download
D chrome/browser/chromeos/testdata/startup_manifest.json View 1 chunk +0 lines, -23 lines 0 comments Download
M chrome/chrome_browser.gypi View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/common/chrome_switches.h View 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/common/chrome_switches.cc View 1 chunk +0 lines, -8 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
dr
10 years, 5 months ago (2010-07-17 16:50:45 UTC) #1
Nikita (slow)
http://codereview.chromium.org/3026006/diff/1/5 File chrome/browser/chromeos/login/string_fetcher.cc (right): http://codereview.chromium.org/3026006/diff/1/5#newcode14 chrome/browser/chromeos/login/string_fetcher.cc:14: GURL url(url_str); check that URL is valid? http://codereview.chromium.org/3026006/diff/1/5#newcode43 chrome/browser/chromeos/login/string_fetcher.cc:43: ...
10 years, 5 months ago (2010-07-19 12:31:19 UTC) #2
Nikita (slow)
10 years, 5 months ago (2010-07-19 12:54:25 UTC) #3
http://codereview.chromium.org/3026006/diff/1/7
File chrome/browser/chromeos/login/wizard_controller.cc (right):

http://codereview.chromium.org/3026006/diff/1/7#newcode736
chrome/browser/chromeos/login/wizard_controller.cc:736:
chromeos::CrosLibrary::Get()->GetLoginLibrary()->EmitLoginPromptReady();
Possible solution:
1. Change Chrome locale only, show welcome screen
2. Postpone switching system wide locale till underlying services are ready
(login_prompt_ready emitted).

With this solution it's fine to leave emitting login_prompt_ready after
controller->Show() as it was. 
In all cases for non-OOBE case it should be leaved unchanged.

Powered by Google App Engine
This is Rietveld 408576698