Landing OEM customization CL for Denis...

Landing OEM customization CL for Denis

Original CL http://codereview.chromium.org/3026006

Fixed problems with initial locale change freezing Chrome OS on the device.
Added creation of /home/chronos/.oobe_completed flag file.
Removed command line switches for testing customization manifests.
Added StringFetcher class implementation - URL fetcher that downloads content into std::string.
Refactored services customization integration.
Removed sample manifests from Chrome repository. They are submitted into Chromium OS repository at chromeos/src/platform/assets/oem_customization.

BUG=http://crosbug.com/1888
TEST=Manual. Changes to OEM customization manifests on partner partition, namely the initial locale, time zone, and startup page attributes should change OOBE UX accordingly.


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=53641

[Nikita (slow), 2010-07-26 10:28:44]

http://codereview.chromium.org/3064002/diff/11004/21005
File chrome/browser/chromeos/login/string_fetcher.cc (right):

http://codereview.chromium.org/3064002/diff/11004/21005#newcode15
chrome/browser/chromeos/login/string_fetcher.cc:15: DCHECK(url.is_valid());
What will happen in release if URL is not valid?
We'll return 404?

http://codereview.chromium.org/3064002/diff/11004/21005#newcode44
chrome/browser/chromeos/login/string_fetcher.cc:44: result_ = data;
Should't we call a delegate (wizard) when manifest has been fetched so that we
could start applying customizations as early as possible.

It's totally fine with current implementation
- Fetch from file
- Not installing apps/extensions.

But not ready for the case when apps/extensions will be downloaded & installed.

http://codereview.chromium.org/3064002/diff/11004/21007
File chrome/browser/chromeos/login/wizard_controller.cc (right):

http://codereview.chromium.org/3064002/diff/11004/21007#newcode61
chrome/browser/chromeos/login/wizard_controller.cc:61: // TODO(denisromanov):
Change this to real URL when it becomes available.
We should have an issue to track this.

http://codereview.chromium.org/3064002/diff/11004/21007#newcode372
chrome/browser/chromeos/login/wizard_controller.cc:372:
NewRunnableFunction(&DeleteWizardControllerAndApplyCustomization,
We rely on the fact that StringFetcher will fetch manifest before this method
will be executed.

[Dmitry Polukhin, 2010-07-26 13:57:29]

http://codereview.chromium.org/3064002/diff/11004/21005
File chrome/browser/chromeos/login/string_fetcher.cc (right):

http://codereview.chromium.org/3064002/diff/11004/21005#newcode15
chrome/browser/chromeos/login/string_fetcher.cc:15: DCHECK(url.is_valid());
On 2010/07/26 10:28:44, Nikita Kostylev wrote:
> What will happen in release if URL is not valid?
> We'll return 404?

Done.

http://codereview.chromium.org/3064002/diff/11004/21005#newcode44
chrome/browser/chromeos/login/string_fetcher.cc:44: result_ = data;
On 2010/07/26 10:28:44, Nikita Kostylev wrote:
> Should't we call a delegate (wizard) when manifest has been fetched so that we
> could start applying customizations as early as possible.
> 
> It's totally fine with current implementation
> - Fetch from file
> - Not installing apps/extensions.
> 
> But not ready for the case when apps/extensions will be downloaded &
installed.

It is tricky. We might delete WizardController so we can't do it here. To keep
things on server we need to change this code anyway.

http://codereview.chromium.org/3064002/diff/11004/21007
File chrome/browser/chromeos/login/wizard_controller.cc (right):

http://codereview.chromium.org/3064002/diff/11004/21007#newcode61
chrome/browser/chromeos/login/wizard_controller.cc:61: // TODO(denisromanov):
Change this to real URL when it becomes available.
On 2010/07/26 10:28:44, Nikita Kostylev wrote:
> We should have an issue to track this.

Done. http://code.google.com/p/chromium-os/issues/detail?id=5123

http://codereview.chromium.org/3064002/diff/11004/21007#newcode372
chrome/browser/chromeos/login/wizard_controller.cc:372:
NewRunnableFunction(&DeleteWizardControllerAndApplyCustomization,
On 2010/07/26 10:28:44, Nikita Kostylev wrote:
> We rely on the fact that StringFetcher will fetch manifest before this method
> will be executed. Yes, should be fixed later
http://code.google.com/p/chromium-os/issues/detail?id=5123

[Nikita (slow), 2010-07-26 15:05:24]

LGTM

http://codereview.chromium.org/3064002/diff/5002/30005
File chrome/browser/chromeos/login/string_fetcher.cc (right):

http://codereview.chromium.org/3064002/diff/5002/30005#newcode18
chrome/browser/chromeos/login/string_fetcher.cc:18: response_code_ = 404;
return;