Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(136)

Issue 2876034: Sorry, this is making the Heapcheck bot unhappy. http://build.chromium.org/b... (Closed)

Created:
10 years, 5 months ago by vandebo (ex-Chrome)
Modified:
9 years, 7 months ago
Reviewers:
erg
CC:
chromium-reviews, ben+cc_chromium.org, Paweł Hajdan Jr.
Visibility:
Public.

Description

Sorry, this is making the Heapcheck bot unhappy. http://build.chromium.org/buildbot/memory/builders/Linux%20Heapcheck/builds/4501/steps/heapcheck%20test:%20unit/logs/stdio i.e. The 197 largest leaks: Leak of 128 bytes in 1 objects allocated from: @ ed9000 __gnu_cxx::new_allocator::allocate @ ed9027 std::_Vector_base::_M_allocate @ ed932c std::vector::_M_insert_aux @ ed94e4 std::vector::push_back @ ed59b2 HostContentSettingsMap::GetSettingsForOneType @ 11f2edb ContentExceptionsTableModel @ e491e1 ContentExceptionsWindowGtk @ 5fdbb7 ContentExceptionsWindowGtkUnittest::BuildWindow @ 5facf2 ContentExceptionsWindowGtkUnittest_TestComplexRemoval_Test::TestBody @ 15b7dfd testing::Test::Run @ 15bb5f2 testing::internal::TestInfoImpl::Run @ 15bb728 testing::TestCase::Run @ 15bc18a testing::internal::UnitTestImpl::RunAllTests @ 15bc301 testing::UnitTest::Run @ 14b7b33 TestSuite::Run @ 14b627d main @ 2b410ff7e1c4 __libc_start_main Revert 51450 - Reland r51414: "GTK: Fix sorting in content exception window." Don't use scoped_ptr in unit test. Manually delete the dailog (which deletes ContentExceptionsWindowGtk.) First Review URL: http://codereview.chromium.org/2876032 BUG=47841 TEST=ContentExceptionsWindowGtkUnittest.* + see bug. Ran valgrind on several gtk tests including new ones and fixed the memory errors. Review URL: http://codereview.chromium.org/2881009 TBR=erg@google.com Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=51476

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -259 lines) Patch
M chrome/browser/gtk/options/content_exceptions_window_gtk.h View 3 chunks +1 line, -12 lines 0 comments Download
M chrome/browser/gtk/options/content_exceptions_window_gtk.cc View 5 chunks +14 lines, -38 lines 0 comments Download
D chrome/browser/gtk/options/content_exceptions_window_gtk_unittest.cc View 1 chunk +0 lines, -208 lines 0 comments Download
M chrome/chrome_tests.gypi View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 1 (0 generated)
vandebo (ex-Chrome)
10 years, 5 months ago (2010-07-02 01:53:07 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698