Issue 2881009: Reland r51414: "GTK: Fix sorting in content exception window."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2881009: Reland r51414: "GTK: Fix sorting in content exception window." (Closed)

Created:
10 years, 5 months ago by Elliot Glaysher

Modified:
9 years, 7 months ago

Reviewers:
Evan Martin, Evan Stade

CC:
chromium-reviews, Paweł Hajdan Jr., ben+cc_chromium.org

Base URL:
http://src.chromium.org/git/chromium.git

Visibility:
Public.

Description

Reland r51414: "GTK: Fix sorting in content exception window." Don't use scoped_ptr in unit test. Manually delete the dailog (which deletes ContentExceptionsWindowGtk.) First Review URL: http://codereview.chromium.org/2876032 BUG=47841 TEST=ContentExceptionsWindowGtkUnittest.* + see bug. Ran valgrind on several gtk tests including new ones and fixed the memory errors. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=51450

Patch Set 1 #

Created: 10 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+260 lines, -16 lines)			Patch
M	chrome/browser/gtk/options/content_exceptions_window_gtk.h	View	3 chunks	+12 lines, -1 line	0 comments	Download
M	chrome/browser/gtk/options/content_exceptions_window_gtk.cc	View	5 chunks	+39 lines, -15 lines	0 comments	Download
A	chrome/browser/gtk/options/content_exceptions_window_gtk_unittest.cc	View	1 chunk	+208 lines, -0 lines	0 comments	Download
M	chrome/chrome_tests.gypi	View	1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Evan Martin

10 years, 5 months ago (2010-07-01 22:15:37 UTC) #2

rubber stamp

you may have lost the last line of your commit message

Expand Messages | Collapse Messages