Issue 2876032: GTK: Fix sorting in content exception window.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2876032: GTK: Fix sorting in content exception window. (Closed)

Created:
10 years, 5 months ago by Elliot Glaysher

Modified:
9 years, 7 months ago

Reviewers:
Evan Martin, Evan Stade

CC:
chromium-reviews, ben+cc_chromium.org, Paweł Hajdan Jr.

Base URL:
http://src.chromium.org/git/chromium.git

Visibility:
Public.

Description

GTK: Fix sorting in content exception window. - Wrap the model in a GtkTreeSortable. This corrects editing of content exception entries in the presence of sorted columns. - Also adds unit tests for this window. BUG=47841 TEST=ContentExceptionsWindowGtkUnittest.* + see bug Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=51415

Patch Set 1 #

Patch Set 2 : comment updates #

Patch Set 3 : Unit tests #

Total comments: 1

Created: 10 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+256 lines, -16 lines)			Patch
M	chrome/browser/gtk/options/content_exceptions_window_gtk.h	View		4 chunks	+13 lines, -1 line	1 comment	Download
M	chrome/browser/gtk/options/content_exceptions_window_gtk.cc	View	1	5 chunks	+39 lines, -15 lines	0 comments	Download
A	chrome/browser/gtk/options/content_exceptions_window_gtk_unittest.cc	View		1 chunk	+203 lines, -0 lines	0 comments	Download
M	chrome/chrome_tests.gypi	View		1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Evan Martin

10 years, 5 months ago (2010-07-01 20:13:11 UTC) #2

LGTM

http://codereview.chromium.org/2876032/diff/5001/6002
File chrome/browser/gtk/options/content_exceptions_window_gtk.h (right):

http://codereview.chromium.org/2876032/diff/5001/6002#newcode13
chrome/browser/gtk/options/content_exceptions_window_gtk.h:13: #include
"base/gtest_prod_util.h"
Unnecessary?

Expand Messages | Collapse Messages