Issue 2868082: AutoFill: Collect UMA stats for AutoFill CC InfoBar.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2868082: AutoFill: Collect UMA stats for AutoFill CC InfoBar. (Closed)

Created:
10 years, 4 months ago by James Hawkins

Modified:
9 years, 7 months ago

Reviewers:
jar (doing other things), dhollowa

CC:
chromium-reviews, ben+cc_chromium.org

Visibility:
Public.

Description

AutoFill: Collect UMA stats for AutoFill CC InfoBar. BUG=50573 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=54185

Patch Set 1 #

Total comments: 1

Created: 10 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -0 lines)			Patch
	M	chrome/browser/autofill/autofill_cc_infobar_delegate.cc	View		3 chunks	+3 lines, -0 lines	1 comment	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

jar (doing other things)

10 years, 3 months ago (2010-09-17 16:43:11 UTC) #3

http://codereview.chromium.org/2868082/diff/1/2
File chrome/browser/autofill/autofill_cc_infobar_delegate.cc (right):

http://codereview.chromium.org/2868082/diff/1/2#newcode84
chrome/browser/autofill/autofill_cc_infobar_delegate.cc:84:
UMA_HISTOGRAM_COUNTS("AutoFill.CCInfoBarAccepted", 1);
Rather than using two separate histograms, you should have had a common function
that records one histogram, with two distinct enumerated values.  That way you
could see the ratios of the counts directly (rather than using a histogram as a
solo counter).  Note that each of the above HISTOGRAM_COUNTS cost about 1K of
storage, whereas a single small HISTOGRAM_ENUMERATION would probably use barely
100 bytes.... and also reduce upload bandwidth and log storage costs etc.

Please feel free to ask for a code review when you're creating future histograms
as well.

Expand Messages | Collapse Messages