AutoFill: Collect UMA stats for AutoFill CC InfoBar.

chrome/browser/autofill/autofill_cc_infobar_delegate.cc

Index: chrome/browser/autofill/autofill_cc_infobar_delegate.cc
diff --git a/chrome/browser/autofill/autofill_cc_infobar_delegate.cc b/chrome/browser/autofill/autofill_cc_infobar_delegate.cc
index 36bde07e8024afe8c8cb9035e5a016f5b04f843c..89c17ba6d2a66a12b2065f34a5bf44ee40b751fb 100644
--- a/chrome/browser/autofill/autofill_cc_infobar_delegate.cc
+++ b/chrome/browser/autofill/autofill_cc_infobar_delegate.cc
@@ -6,6 +6,7 @@
 
 #include "app/l10n_util.h"
 #include "app/resource_bundle.h"
+#include "base/histogram.h"
 #include "chrome/browser/autofill/autofill_cc_infobar.h"
 #include "chrome/browser/autofill/autofill_manager.h"
 #include "chrome/browser/browser.h"
@@ -80,6 +81,7 @@ std::wstring AutoFillCCInfoBarDelegate::GetButtonLabel(
 }
 
 bool AutoFillCCInfoBarDelegate::Accept() {
+  UMA_HISTOGRAM_COUNTS("AutoFill.CCInfoBarAccepted", 1);

[jar (doing other things), 2010/09/17 16:43:11]

Rather than using two separate histograms, you should have had a common function
that records one histogram, with two distinct enumerated values.  That way you
could see the ratios of the counts directly (rather than using a histogram as a
solo counter).  Note that each of the above HISTOGRAM_COUNTS cost about 1K of
storage, whereas a single small HISTOGRAM_ENUMERATION would probably use barely
100 bytes.... and also reduce upload bandwidth and log storage costs etc.

Please feel free to ask for a code review when you're creating future histograms
as well.

   if (host_) {
     host_->OnInfoBarClosed(true);
     host_ = NULL;
@@ -88,6 +90,7 @@ bool AutoFillCCInfoBarDelegate::Accept() {
 }
 
 bool AutoFillCCInfoBarDelegate::Cancel() {
+  UMA_HISTOGRAM_COUNTS("AutoFill.CCInfoBarDenied", 1);
   if (host_) {
     host_->OnInfoBarClosed(false);
     host_ = NULL;