AutoFill: Collect UMA stats for AutoFill CC InfoBar.

chrome/browser/autofill/autofill_cc_infobar_delegate.cc

 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/autofill/autofill_cc_infobar_delegate.h"
 
 #include "app/l10n_util.h"
 #include "app/resource_bundle.h"
+#include "base/histogram.h"
 #include "chrome/browser/autofill/autofill_cc_infobar.h"
 #include "chrome/browser/autofill/autofill_manager.h"
 #include "chrome/browser/browser.h"
 #include "chrome/browser/pref_service.h"
 #include "chrome/browser/profile.h"
 #include "chrome/browser/tab_contents/tab_contents.h"
 #include "chrome/browser/tab_contents/tab_contents_delegate.h"
 #include "chrome/common/pref_names.h"
 #include "grit/chromium_strings.h"
 #include "grit/generated_resources.h"
@@ skipping 54 matching lines @@
     return l10n_util::GetString(IDS_AUTOFILL_CC_INFOBAR_ACCEPT);
   else if (button == BUTTON_CANCEL)
     return l10n_util::GetString(IDS_AUTOFILL_CC_INFOBAR_DENY);
   else
     NOTREACHED();
 
   return std::wstring();
 }
 
 bool AutoFillCCInfoBarDelegate::Accept() {
+  UMA_HISTOGRAM_COUNTS("AutoFill.CCInfoBarAccepted", 1);

[jar (doing other things), 2010/09/17 16:43:11]

Rather than using two separate histograms, you should have had a common function
that records one histogram, with two distinct enumerated values.  That way you
could see the ratios of the counts directly (rather than using a histogram as a
solo counter).  Note that each of the above HISTOGRAM_COUNTS cost about 1K of
storage, whereas a single small HISTOGRAM_ENUMERATION would probably use barely
100 bytes.... and also reduce upload bandwidth and log storage costs etc.

Please feel free to ask for a code review when you're creating future histograms
as well.

   if (host_) {
     host_->OnInfoBarClosed(true);
     host_ = NULL;
   }
   return true;
 }
 
 bool AutoFillCCInfoBarDelegate::Cancel() {
+  UMA_HISTOGRAM_COUNTS("AutoFill.CCInfoBarDenied", 1);
   if (host_) {
     host_->OnInfoBarClosed(false);
     host_ = NULL;
   }
   return true;
 }
 
 std::wstring AutoFillCCInfoBarDelegate::GetLinkText() {
   return l10n_util::GetString(IDS_AUTOFILL_CC_LEARN_MORE);
 }
 
 bool AutoFillCCInfoBarDelegate::LinkClicked(WindowOpenDisposition disposition) {
   browser_->OpenURL(GURL(kAutoFillLearnMoreUrl), GURL(), NEW_FOREGROUND_TAB,
                     PageTransition::TYPED);
   return false;
 }
 
 #if defined(OS_WIN)
 InfoBar* AutoFillCCInfoBarDelegate::CreateInfoBar() {
   return CreateAutofillCcInfoBar(this);
 }
 #endif  // defined(OS_WIN)