Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(449)

Issue 2861039: Revert 51231 - Loosen permission on extension temp dir when a flag is used.... (Closed)

Created:
10 years, 5 months ago by Sam Kerner (Chrome)
Modified:
9 years, 7 months ago
CC:
chromium-reviews, ben+cc_chromium.org, John Grabowski, Erik does not do reviews, Paweł Hajdan Jr., Aaron Boodman, pam+watch_chromium.org, brettw-cc_chromium.org
Visibility:
Public.

Description

Revert 51231 - Loosen permission on extension temp dir when a flag is used. Issue 35198 can not be reproduced locally. To enable users to do experiments, three command line flags are added to chrome: --issue35198-crxdir-browser: Have the browser process create the directory in which the extension will be unzipped. --issue35198-logging: Enable log messages from directory creation in the utility process to be moved to the browser process. --issue35198-permission: Use the most permissive file permissions possible on the extension unpack directory. BUG=35198 TEST=manual Review URL: http://codereview.chromium.org/2802018 TBR=skerner@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=51238

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -143 lines) Patch
M base/file_util.h View 1 chunk +1 line, -2 lines 0 comments Download
M base/file_util_posix.cc View 1 chunk +1 line, -9 lines 0 comments Download
M base/file_util_unittest.cc View 1 chunk +1 line, -2 lines 0 comments Download
M base/file_util_win.cc View 5 chunks +3 lines, -70 lines 0 comments Download
M base/scoped_temp_dir.h View 1 chunk +1 line, -2 lines 0 comments Download
M base/scoped_temp_dir.cc View 2 chunks +4 lines, -9 lines 0 comments Download
M base/scoped_temp_dir_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/sandboxed_extension_unpacker.cc View 3 chunks +4 lines, -20 lines 0 comments Download
M chrome/browser/utility_process_host.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/common/chrome_switches.h View 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/common/chrome_switches.cc View 1 chunk +0 lines, -7 lines 0 comments Download
M chrome/common/extensions/extension_unpacker.cc View 3 chunks +2 lines, -15 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
Sam Kerner (Chrome)
10 years, 5 months ago (2010-06-30 07:18:18 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698