Loosen permission on extension temp dir when a flag is used.

Loosen permission on extension temp dir when a flag is used.

Issue 35198 can not be reproduced locally.  To enable users to do experiments, three command line flags are added to chrome:

--issue35198-crxdir-browser: Have the browser process create the directory in which the extension will be unzipped.

--issue35198-logging: Enable log messages from directory creation in the utility process to be moved to the browser process.  

--issue35198-permission: Use the most permissive file permissions possible on the extension unpack directory.


BUG=35198
TEST=manual

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=51231

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=51416

[tkent, 2010-06-29 05:01:39]

LGTM.
I don't like such ugly command-line switches, but we need them...

[Sam Kerner (Chrome), 2010-06-29 15:13:10]

On 2010/06/29 05:01:39, Kent Tamura wrote:
>
> I don't like such ugly command-line switches, but we need them...

I don't like them either.  I tried to avoid them by mailing patches to users who
see the issue and mentioned that they have visual studio installed.  That did
not work out, and this is the only other way I can think of.

[darin (slow to review), 2010-06-30 06:16:02]

http://codereview.chromium.org/2802018/diff/3006/17001
File base/file_util.h (right):

http://codereview.chromium.org/2802018/diff/3006/17001#newcode271
base/file_util.h:271: bool lossen_permissions);
style-nit: out parameters are supposed to be listed last.

http://google-styleguide.googlecode.com/svn/trunk/cppguide.xml?showone=Functi...

i think you may have meant to name this parameter loosen_permissions.  also
please document the meaning of this new parameter.  it is not obvious.

http://codereview.chromium.org/2802018/diff/3006/17002
File base/file_util_posix.cc (right):

http://codereview.chromium.org/2802018/diff/3006/17002#newcode437
base/file_util_posix.cc:437: // loosen_permissions == true on non-windows
plarforms.
plarforms -> platforms

[Sam Kerner (Chrome), 2010-06-30 18:46:03]

http://codereview.chromium.org/2802018/diff/3006/17001
File base/file_util.h (right):

http://codereview.chromium.org/2802018/diff/3006/17001#newcode271
base/file_util.h:271: bool lossen_permissions);
On 2010/06/30 06:16:02, darin wrote:
> style-nit: out parameters are supposed to be listed last.
> 
>
http://google-styleguide.googlecode.com/svn/trunk/cppguide.xml?showone=Functi...
> 
> i think you may have meant to name this parameter loosen_permissions.  also
> please document the meaning of this new parameter.  it is not obvious.

Done.

http://codereview.chromium.org/2802018/diff/3006/17002
File base/file_util_posix.cc (right):

http://codereview.chromium.org/2802018/diff/3006/17002#newcode437
base/file_util_posix.cc:437: // loosen_permissions == true on non-windows
plarforms.
On 2010/06/30 06:16:02, darin wrote:
> plarforms -> platforms

Fixed this and "possible".

[darin (slow to review), 2010-07-01 17:07:25]

LGTM

http://codereview.chromium.org/2802018/diff/15002/24002
File base/file_util_posix.cc (right):

http://codereview.chromium.org/2802018/diff/15002/24002#newcode438
base/file_util_posix.cc:438: CHECK(!loosen_permissions);
nit: I think this can just be a DCHECK since you are trying to slap developers
for misusing this function.  you don't need a crash report do you?

[Sam Kerner (Chrome), 2010-07-01 20:15:08]

http://codereview.chromium.org/2802018/diff/15002/24002
File base/file_util_posix.cc (right):

http://codereview.chromium.org/2802018/diff/15002/24002#newcode438
base/file_util_posix.cc:438: CHECK(!loosen_permissions);
On 2010/07/01 17:07:25, darin wrote:
> nit: I think this can just be a DCHECK since you are trying to slap developers
> for misusing this function.  you don't need a crash report do you?

Changed to DCHECK.