Revert 51231 - Loosen permission on extension temp dir when a flag is used....

chrome/common/extensions/extension_unpacker.cc

 // Copyright (c) 2009 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/common/extensions/extension_unpacker.h"
 
-#include "base/command_line.h"
 #include "base/file_util.h"
 #include "base/scoped_handle.h"
 #include "base/scoped_temp_dir.h"
 #include "base/string_util.h"
 #include "base/thread.h"
 #include "base/values.h"
 #include "net/base/file_stream.h"
-#include "chrome/common/chrome_switches.h"
 #include "chrome/common/common_param_traits.h"
 #include "chrome/common/extensions/extension.h"
 #include "chrome/common/extensions/extension_constants.h"
 #include "chrome/common/extensions/extension_file_util.h"
 #include "chrome/common/extensions/extension_l10n_util.h"
 #include "chrome/common/json_value_serializer.h"
 #include "chrome/common/notification_service.h"
 #include "chrome/common/url_constants.h"
 #include "chrome/common/zip.h"
 #include "ipc/ipc_message_utils.h"
@@ skipping 111 matching lines @@
 }
 
 bool ExtensionUnpacker::Run() {
   LOG(INFO) << "Installing extension " << extension_path_.value();
 
   // <profile>/Extensions/INSTALL_TEMP/<version>
   temp_install_dir_ =
     extension_path_.DirName().AppendASCII(filenames::kTempExtensionName);
 
 #if defined(OS_WIN)
-  // To understand crbug/35198, allow users who can reproduce the issue
-  // to enable extra logging while unpacking.
-  bool extra_logging = CommandLine::ForCurrentProcess()->HasSwitch(
-      switches::kIssue35198ExtraLogging);
-  LOG(INFO) << "Extra logging for issue 35198: " << extra_logging;
-
   std::ostringstream log_stream;
   std::string dir_string = WideToUTF8(temp_install_dir_.value());
   log_stream << kCouldNotCreateDirectoryError << dir_string << std::endl;
-
   if (!file_util::CreateDirectoryExtraLogging(temp_install_dir_, log_stream)) {
-    if (extra_logging) {
-      log_stream.flush();
-      SetError(log_stream.str());
-    } else {
-      SetError(kCouldNotCreateDirectoryError + dir_string);
-    }
+    log_stream.flush();
+    SetError(log_stream.str());
     return false;
   }
 #else
   if (!file_util::CreateDirectory(temp_install_dir_)) {
     std::string dir_string = temp_install_dir_.value();
     SetError(kCouldNotCreateDirectoryError + dir_string);
     return false;
   }
 #endif
 
@@ skipping 141 matching lines @@
 
   parsed_catalogs_->Set(relative_path.DirName().ToWStringHack(),
                         root.release());
 
   return true;
 }
 
 void ExtensionUnpacker::SetError(const std::string &error) {
   error_message_ = error;
 }