Issue 2855018: X64: Change strategy for spilling to match ia32. It's just better.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2855018: X64: Change strategy for spilling to match ia32. It's just better. (Closed)

Created:
10 years, 6 months ago by Lasse Reichstein

Modified:
9 years, 6 months ago

Reviewers:
William Hesse

CC:
v8-dev

Visibility:
Public.

Description

X64: Change strategy for spilling to match ia32. It's just better. Align deferred code blocks to 16-byte address boundaries.

Patch Set 1 #

Total comments: 1

Patch Set 2 : Addressed review comments #

Created: 10 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+33 lines, -14 lines)			Patch
M	src/arm/assembler-arm.h	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	src/arm/assembler-arm.cc	View		1 chunk	+5 lines, -0 lines	0 comments	Download
M	src/codegen.cc	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	src/ia32/assembler-ia32.h	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	src/ia32/assembler-ia32.cc	View		1 chunk	+5 lines, -0 lines	0 comments	Download
M	src/x64/assembler-x64.h	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	src/x64/assembler-x64.cc	View		1 chunk	+5 lines, -0 lines	0 comments	Download
M	src/x64/macro-assembler-x64.cc	View		1 chunk	+1 line, -6 lines	0 comments	Download
M	src/x64/virtual-frame-x64.cc	View	1	1 chunk	+10 lines, -8 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

William Hesse

10 years, 6 months ago (2010-06-22 09:22:57 UTC) #2

LGTM.

http://codereview.chromium.org/2855018/diff/1/10
File src/x64/virtual-frame-x64.cc (right):

http://codereview.chromium.org/2855018/diff/1/10#newcode964
src/x64/virtual-frame-x64.cc:964: // TODO(lrn): Can we assert (end >
stack_pointer_)?
Resolve this TODO now.  I doubt it, and it probably isn't a good idea.

Expand Messages | Collapse Messages