Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(358)

Side by Side Diff: src/ia32/assembler-ia32.cc

Issue 2855018: X64: Change strategy for spilling to match ia32. It's just better. (Closed)
Patch Set: Addressed review comments Created 10 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/ia32/assembler-ia32.h ('k') | src/x64/assembler-x64.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 1994-2006 Sun Microsystems Inc. 1 // Copyright (c) 1994-2006 Sun Microsystems Inc.
2 // All Rights Reserved. 2 // All Rights Reserved.
3 // 3 //
4 // Redistribution and use in source and binary forms, with or without 4 // Redistribution and use in source and binary forms, with or without
5 // modification, are permitted provided that the following conditions 5 // modification, are permitted provided that the following conditions
6 // are met: 6 // are met:
7 // 7 //
8 // - Redistributions of source code must retain the above copyright notice, 8 // - Redistributions of source code must retain the above copyright notice,
9 // this list of conditions and the following disclaimer. 9 // this list of conditions and the following disclaimer.
10 // 10 //
(...skipping 360 matching lines...) Expand 10 before | Expand all | Expand 10 after
371 371
372 372
373 void Assembler::Align(int m) { 373 void Assembler::Align(int m) {
374 ASSERT(IsPowerOf2(m)); 374 ASSERT(IsPowerOf2(m));
375 while ((pc_offset() & (m - 1)) != 0) { 375 while ((pc_offset() & (m - 1)) != 0) {
376 nop(); 376 nop();
377 } 377 }
378 } 378 }
379 379
380 380
381 void Assembler::CodeTargetAlign() {
382 Align(16); // Preferred alignment of jump targets on ia32.
383 }
384
385
381 void Assembler::cpuid() { 386 void Assembler::cpuid() {
382 ASSERT(CpuFeatures::IsEnabled(CPUID)); 387 ASSERT(CpuFeatures::IsEnabled(CPUID));
383 EnsureSpace ensure_space(this); 388 EnsureSpace ensure_space(this);
384 last_pc_ = pc_; 389 last_pc_ = pc_;
385 EMIT(0x0F); 390 EMIT(0x0F);
386 EMIT(0xA2); 391 EMIT(0xA2);
387 } 392 }
388 393
389 394
390 void Assembler::pushad() { 395 void Assembler::pushad() {
(...skipping 2196 matching lines...) Expand 10 before | Expand all | Expand 10 after
2587 fprintf(coverage_log, "%s\n", file_line); 2592 fprintf(coverage_log, "%s\n", file_line);
2588 fflush(coverage_log); 2593 fflush(coverage_log);
2589 } 2594 }
2590 } 2595 }
2591 2596
2592 #endif 2597 #endif
2593 2598
2594 } } // namespace v8::internal 2599 } } // namespace v8::internal
2595 2600
2596 #endif // V8_TARGET_ARCH_IA32 2601 #endif // V8_TARGET_ARCH_IA32
OLDNEW
« no previous file with comments | « src/ia32/assembler-ia32.h ('k') | src/x64/assembler-x64.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698