Deprecate more old filepath functions.

Deprecate most of the remaining wstring file_util functions.

These still exist on Windows due to being used by the installer,
but by moving them into the Windows-only block we prevent them
from being used in new code.  (I am already finding new code using
some of these!  I am glad to be rid of them.)
    
BUG=24672
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=51862

[Evan Martin, 2010-07-08 16:51:11]

http://codereview.chromium.org/2850042/diff/15001/16009
File chrome/tools/convert_dict/aff_reader.cc (right):

http://codereview.chromium.org/2850042/diff/15001/16009#newcode51
chrome/tools/convert_dict/aff_reader.cc:51: FilePath path =
FilePath::FromWStringHack(ASCIIToWide(filename));
I am going to improve this in a follow-up change.

[Evan Martin, 2010-07-08 17:25:25]

+thiago FYI

[tfarina, 2010-07-08 17:33:11]

http://codereview.chromium.org/2850042/diff/15001/16003
File chrome/browser/download/download_manager.cc (right):

http://codereview.chromium.org/2850042/diff/15001/16003#newcode1331
chrome/browser/download/download_manager.cc:1331: if (!extension.empty())
The same code block is written in save_package.cc. Would be could to refactor it
to some place?

http://codereview.chromium.org/2850042/diff/15001/16007
File chrome/browser/shell_integration.cc (right):

http://codereview.chromium.org/2850042/diff/15001/16007#newcode26
chrome/browser/shell_integration.cc:26: arguments_w += std::wstring(L"--") +
ASCIIToWide(switches::kUserDataDir) +
There is a TODO in some other place about using the command line API, would be
good to add one here too?

[Nico, 2010-07-08 17:37:27]

Nice! LG. Everything below are just nits.

http://codereview.chromium.org/2850042/diff/15001/16003
File chrome/browser/download/download_manager.cc (right):

http://codereview.chromium.org/2850042/diff/15001/16003#newcode1332
chrome/browser/download/download_manager.cc:1332:
extension.erase(extension.begin());  // Erase preceding '.'.
Should there be an "ExtensionWithoutDot" method on FilePath?

http://codereview.chromium.org/2850042/diff/15001/16008
File chrome/browser/shell_integration.h (right):

http://codereview.chromium.org/2850042/diff/15001/16008#newcode74
chrome/browser/shell_integration.h:74: // XXX This function is dangerous, do not
use!  You cannot treat
If you want to check this in, s/XXX/NOTE/

http://codereview.chromium.org/2850042/diff/15001/16010
File chrome/tools/convert_dict/dic_reader.cc (right):

http://codereview.chromium.org/2850042/diff/15001/16010#newcode133
chrome/tools/convert_dict/dic_reader.cc:133: file_ = file_util::OpenFile(path,
"r");
also followup change?

http://codereview.chromium.org/2850042/diff/15001/16010#newcode135
chrome/tools/convert_dict/dic_reader.cc:135:
file_util::OpenFile(FilePath(path.value() + FILE_PATH_LITERAL("_delta")),
InsertBeforeExtension?

[Evan Martin, 2010-07-08 17:48:47]

Thanks

http://codereview.chromium.org/2850042/diff/15001/16003
File chrome/browser/download/download_manager.cc (right):

http://codereview.chromium.org/2850042/diff/15001/16003#newcode1331
chrome/browser/download/download_manager.cc:1331: if (!extension.empty())
On 2010/07/08 17:33:11, tfarina wrote:
> The same code block is written in save_package.cc. Would be could to refactor
it
> to some place?

Yes, I think perhaps including the "." in the Extension() return value was a bad
idea.  I think I should maybe change Extension() to not include the "." and then
fix all the callers too.

http://codereview.chromium.org/2850042/diff/15001/16007
File chrome/browser/shell_integration.cc (right):

http://codereview.chromium.org/2850042/diff/15001/16007#newcode26
chrome/browser/shell_integration.cc:26: arguments_w += std::wstring(L"--") +
ASCIIToWide(switches::kUserDataDir) +
On 2010/07/08 17:33:11, tfarina wrote:
> There is a TODO in some other place about using the command line API, would be
> good to add one here too?

Done.