Deprecate more old filepath functions.

chrome/browser/download/download_manager.cc

 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/download/download_manager.h"
 
 #include "app/l10n_util.h"
 #include "app/resource_bundle.h"
 #include "base/callback.h"
 #include "base/file_util.h"
@@ skipping 1309 matching lines @@
   //    guess a reasonable file extension based on the content type.
   //
   // 3) Shell integration.  Some file extensions automatically integrate with
   //    the shell.  We block these extensions to prevent a malicious web site
   //    from integrating with the user's shell.
 
   static const FilePath::CharType default_extension[] =
       FILE_PATH_LITERAL("download");
 
   // See if our file name already contains an extension.
-  FilePath::StringType extension(
-      file_util::GetFileExtensionFromPath(file_name));
+  FilePath::StringType extension = file_name.Extension();
+  if (!extension.empty())

[tfarina, 2010/07/08 17:33:11]

The same code block is written in save_package.cc. Would be could to refactor it
to some place?

[Evan Martin, 2010/07/08 17:48:47]

Yes, I think perhaps including the "." in the Extension() return value was a bad
idea.  I think I should maybe change Extension() to not include the "." and then
fix all the callers too.

+    extension.erase(extension.begin());  // Erase preceding '.'.

[Nico, 2010/07/08 17:37:28]

Should there be an "ExtensionWithoutDot" method on FilePath?

 
 #if defined(OS_WIN)
   // Rename shell-integrated extensions.
   if (win_util::IsShellIntegratedExtension(extension))
     extension.assign(default_extension);
 #endif
 
   std::string mime_type_from_extension;
   net::GetMimeTypeFromFile(file_name,
                            &mime_type_from_extension);
@@ skipping 497 matching lines @@
   observing_download_manager_->NotifyModelChanged();
 }
 
 void DownloadManager::OtherDownloadManagerObserver::SetDownloads(
     std::vector<DownloadItem*>& downloads) {
 }
 
 void DownloadManager::OtherDownloadManagerObserver::ManagerGoingDown() {
   observed_download_manager_ = NULL;
 }