Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(72)

Side by Side Diff: chrome/browser/shell_integration.h

Issue 2850042: Deprecate more old filepath functions. (Closed)
Patch Set: rebase Created 10 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2010 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_SHELL_INTEGRATION_H_ 5 #ifndef CHROME_BROWSER_SHELL_INTEGRATION_H_
6 #define CHROME_BROWSER_SHELL_INTEGRATION_H_ 6 #define CHROME_BROWSER_SHELL_INTEGRATION_H_
7 7
8 #include <string> 8 #include <string>
9 9
10 #include "base/basictypes.h" 10 #include "base/basictypes.h"
(...skipping 53 matching lines...) Expand 10 before | Expand all | Expand 10 after
64 // this means "pin to taskbar". For Mac/Linux, this could be used for 64 // this means "pin to taskbar". For Mac/Linux, this could be used for
65 // Mac dock or the gnome/kde application launcher. However, those are not 65 // Mac dock or the gnome/kde application launcher. However, those are not
66 // implemented yet. 66 // implemented yet.
67 bool create_in_quick_launch_bar; 67 bool create_in_quick_launch_bar;
68 }; 68 };
69 69
70 // Re-implementation of chrome_plugin_utill::CPB_GetCommandLineArgumentsCommon 70 // Re-implementation of chrome_plugin_utill::CPB_GetCommandLineArgumentsCommon
71 // which is deprecated. If |extension_app_id| is non-empty, an arguments 71 // which is deprecated. If |extension_app_id| is non-empty, an arguments
72 // string is created using the kAppId=<id> flag. Otherwise, the kApp=<url> is 72 // string is created using the kAppId=<id> flag. Otherwise, the kApp=<url> is
73 // used. 73 // used.
74 // XXX This function is dangerous, do not use! You cannot treat
Nico 2010/07/08 17:37:28 If you want to check this in, s/XXX/NOTE/
75 // command lines as plain strings as there are metacharacters.
74 static std::string GetCommandLineArgumentsCommon(const GURL& url, 76 static std::string GetCommandLineArgumentsCommon(const GURL& url,
75 const string16& extension_app_id); 77 const string16& extension_app_id);
76 78
77 #if defined(USE_X11) 79 #if defined(USE_X11)
78 static bool GetDesktopShortcutTemplate(base::EnvVarGetter* env_getter, 80 static bool GetDesktopShortcutTemplate(base::EnvVarGetter* env_getter,
79 std::string* output); 81 std::string* output);
80 82
81 // Returns filename for .desktop file based on |url|, sanitized for security. 83 // Returns filename for .desktop file based on |url|, sanitized for security.
82 static FilePath GetDesktopShortcutFilename(const GURL& url); 84 static FilePath GetDesktopShortcutFilename(const GURL& url);
83 85
(...skipping 81 matching lines...) Expand 10 before | Expand all | Expand 10 after
165 // state. 167 // state.
166 void UpdateUI(DefaultBrowserState state); 168 void UpdateUI(DefaultBrowserState state);
167 169
168 DefaultBrowserObserver* observer_; 170 DefaultBrowserObserver* observer_;
169 171
170 DISALLOW_COPY_AND_ASSIGN(DefaultBrowserWorker); 172 DISALLOW_COPY_AND_ASSIGN(DefaultBrowserWorker);
171 }; 173 };
172 }; 174 };
173 175
174 #endif // CHROME_BROWSER_SHELL_INTEGRATION_H_ 176 #endif // CHROME_BROWSER_SHELL_INTEGRATION_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698