Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(246)

Issue 2844033: Fix animation bug in ExtensionInfoBar would can result in orphaned instances in the view hierarchy (Closed)

Created:
10 years, 6 months ago by rafaelw
Modified:
9 years, 7 months ago
Reviewers:
Aaron Boodman, Finnur
CC:
chromium-reviews, Erik does not do reviews, pam+watch_chromium.org, ben+cc_chromium.org
Base URL:
http://src.chromium.org/git/chromium.git
Visibility:
Public.

Description

Fix animation bug in ExtensionInfoBar would can result in orphaned instances in the view hierarchy BUG=47576 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=51040

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -1 line) Patch
M chrome/browser/extensions/extension_infobar_delegate.h View 3 chunks +6 lines, -0 lines 0 comments Download
M chrome/browser/extensions/extension_infobar_delegate.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/views/infobars/extension_infobar.cc View 1 chunk +8 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
rafaelw
10 years, 6 months ago (2010-06-26 00:37:24 UTC) #1
Aaron Boodman
lgtm
10 years, 6 months ago (2010-06-26 00:47:23 UTC) #2
Finnur
10 years, 6 months ago (2010-06-26 01:20:06 UTC) #3
Good catch. Thanks!

Powered by Google App Engine
This is Rietveld 408576698