Fix animation bug in ExtensionInfoBar would can result in orphaned instances in the view hierarchy

chrome/browser/views/infobars/extension_infobar.cc

 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/views/infobars/extension_infobar.h"
 
 #include "app/resource_bundle.h"
 #include "app/slide_animation.h"
 #include "chrome/browser/extensions/extension_context_menu_model.h"
 #include "chrome/browser/extensions/extension_infobar_delegate.h"
@@ skipping 49 matching lines @@
 
 ExtensionInfoBar::~ExtensionInfoBar() {
   if (delegate_) {
     delegate_->extension_host()->view()->SetContainer(NULL);
     delegate_->set_observer(NULL);
   }
 }
 
 void ExtensionInfoBar::OnExtensionPreferredSizeChanged(ExtensionView* view) {
   DCHECK(view == delegate_->extension_host()->view());
+  
+  // When the infobar is closed, it animates to 0 vertical height. We'll
+  // continue to get size changed notifications from the ExtensionView, but we
+  // need to ignore them otherwise we'll try to re-animate open (and leak the
+  // infobar view).
+  if (delegate_->closing())
+    return;
+
   delegate_->extension_host()->view()->SetVisible(true);
 
   gfx::Size sz = view->GetPreferredSize();
   // Clamp height to a min and a max size of between 1 and 2 InfoBars.
   int default_height = static_cast<int>(InfoBar::kDefaultTargetHeight);
   sz.set_height(std::max(default_height, sz.height()));
   sz.set_height(std::min(2 * default_height, sz.height()));
 
   if (height() == 0)
     animation()->Reset(0.0);
@@ skipping 85 matching lines @@
     tracker_.LoadImage(extension, icon_resource, gfx::Size(size, size),
                        ImageLoadingTracker::DONT_CACHE);
   } else {
     OnImageLoaded(NULL, icon_resource, 0);  // |image|, |index|.
   }
 }
 
 InfoBar* ExtensionInfoBarDelegate::CreateInfoBar() {
   return new ExtensionInfoBar(this);
 }