chrome/browser/extensions/extension_infobar_delegate.cc - Issue 2844033: Fix animation bug in ExtensionInfoBar would can result in orphaned instances in the view hierarchy

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/extension_infobar_delegate.cc

Issue 2844033: Fix animation bug in ExtensionInfoBar would can result in orphaned instances in the view hierarchy (Closed) Base URL: http://src.chromium.org/git/chromium.git

Patch Set: Created 10 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/extensions/extension_infobar_delegate.cc

diff --git a/chrome/browser/extensions/extension_infobar_delegate.cc b/chrome/browser/extensions/extension_infobar_delegate.cc

index 7bbc79b0af871aec1edb0ea20abbb718a687778b..28bfdf6fb60e19799cf2394705c7e9b96f801664 100644

--- a/chrome/browser/extensions/extension_infobar_delegate.cc

+++ b/chrome/browser/extensions/extension_infobar_delegate.cc

@@ -20,7 +20,8 @@ ExtensionInfoBarDelegate::ExtensionInfoBarDelegate(Browser* browser,

: InfoBarDelegate(tab_contents),

observer_(NULL),

extension_(extension),

- tab_contents_(tab_contents) {

+ tab_contents_(tab_contents),

+ closing_(false) {

ExtensionProcessManager* manager =

browser->profile()->GetExtensionProcessManager();

extension_host_.reset(manager->CreateInfobar(url, browser));

« no previous file with comments | « chrome/browser/extensions/extension_infobar_delegate.h ('k') | chrome/browser/views/infobars/extension_infobar.cc » ('j') | no next file with comments »