Issue 28191: Fixes regression where bookmark bar would appear all black. Actually,...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 28191: Fixes regression where bookmark bar would appear all black. Actually,... (Closed)

Created:
11 years, 10 months ago by sky

Modified:
9 years, 7 months ago

Reviewers:
Peter Kasting

CC:
chromium-reviews_googlegroups.com

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Fixes regression where bookmark bar would appear all black. Actually, it wasn't that the bookmark bar was all black, rather that BrowserView thought the bookmark bar was parented when in fact it wasn't. The black was the result of BrowserView reserving the space for the bookmark bar and not painting anything in it's space. BUG=7922 TEST=see bug Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=10530

Patch Set 1 #

Created: 11 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+9 lines, -23 lines)			Patch
M	chrome/browser/views/bookmark_bar_view.cc	View	1 chunk	+0 lines, -5 lines	0 comments	Download
M	chrome/browser/views/frame/browser_view.h	View	3 chunks	+2 lines, -5 lines	0 comments	Download
M	chrome/browser/views/frame/browser_view.cc	View	6 chunks	+7 lines, -13 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Peter Kasting

11 years, 10 months ago (2009-02-26 19:03:28 UTC) #2

LGTM, getting the perfect solution here is more trouble than it's worth

Expand Messages | Collapse Messages