Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1151)

Unified Diff: chrome/browser/views/bookmark_bar_view.cc

Issue 28191: Fixes regression where bookmark bar would appear all black. Actually,... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: Created 11 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/views/frame/browser_view.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/views/bookmark_bar_view.cc
===================================================================
--- chrome/browser/views/bookmark_bar_view.cc (revision 10408)
+++ chrome/browser/views/bookmark_bar_view.cc (working copy)
@@ -871,11 +871,6 @@
void BookmarkBarView::ViewHierarchyChanged(bool is_add,
View* parent,
View* child) {
- // See http://code.google.com/p/chromium/issues/detail?id=7857 . It seems
- // as though the bookmark bar is getting unintentionally removed.
- DCHECK(testing_ || child != this || is_add ||
- static_cast<BrowserView*>(parent)->is_removing_bookmark_bar());
-
if (is_add && child == this && height() > 0) {
// We only layout while parented. When we become parented, if our bounds
// haven't changed, DidChangeBounds won't get invoked and we won't layout.
« no previous file with comments | « no previous file | chrome/browser/views/frame/browser_view.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698