Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(215)

Side by Side Diff: chrome/browser/views/frame/browser_view.h

Issue 28191: Fixes regression where bookmark bar would appear all black. Actually,... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: Created 11 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « chrome/browser/views/bookmark_bar_view.cc ('k') | chrome/browser/views/frame/browser_view.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2006-2008 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2006-2008 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_VIEWS_FRAME_BROWSER_VIEW_H_ 5 #ifndef CHROME_BROWSER_VIEWS_FRAME_BROWSER_VIEW_H_
6 #define CHROME_BROWSER_VIEWS_FRAME_BROWSER_VIEW_H_ 6 #define CHROME_BROWSER_VIEWS_FRAME_BROWSER_VIEW_H_
7 7
8 #include "chrome/browser/browser.h" 8 #include "chrome/browser/browser.h"
9 #include "chrome/browser/browser_window.h" 9 #include "chrome/browser/browser_window.h"
10 #include "chrome/browser/hang_monitor/hung_plugin_action.h" 10 #include "chrome/browser/hang_monitor/hung_plugin_action.h"
(...skipping 243 matching lines...) Expand 10 before | Expand all | Expand 10 after
254 #ifdef CHROME_PERSONALIZATION 254 #ifdef CHROME_PERSONALIZATION
255 virtual bool IsPersonalizationEnabled() const { 255 virtual bool IsPersonalizationEnabled() const {
256 return personalization_enabled_; 256 return personalization_enabled_;
257 } 257 }
258 258
259 void EnablePersonalization(bool enable_personalization) { 259 void EnablePersonalization(bool enable_personalization) {
260 personalization_enabled_ = enable_personalization; 260 personalization_enabled_ = enable_personalization;
261 } 261 }
262 #endif 262 #endif
263 263
264 bool is_removing_bookmark_bar() const { return is_removing_bookmark_bar_; }
265
266 protected: 264 protected:
267 // Overridden from views::View: 265 // Overridden from views::View:
268 virtual void Layout(); 266 virtual void Layout();
269 virtual void ViewHierarchyChanged(bool is_add, 267 virtual void ViewHierarchyChanged(bool is_add,
270 views::View* parent, 268 views::View* parent,
271 views::View* child); 269 views::View* child);
272 // As long as ShouldForwardToTabStrip returns true, drag and drop methods 270 // As long as ShouldForwardToTabStrip returns true, drag and drop methods
273 // are forwarded to the tab strip. 271 // are forwarded to the tab strip.
274 virtual bool CanDrop(const OSExchangeData& data); 272 virtual bool CanDrop(const OSExchangeData& data);
275 virtual void OnDragEntered(const views::DropTargetEvent& event); 273 virtual void OnDragEntered(const views::DropTargetEvent& event);
(...skipping 96 matching lines...) Expand 10 before | Expand all | Expand 10 after
372 // Initialize class statics. 370 // Initialize class statics.
373 static void InitClass(); 371 static void InitClass();
374 372
375 // The BrowserFrame that hosts this view. 373 // The BrowserFrame that hosts this view.
376 BrowserFrame* frame_; 374 BrowserFrame* frame_;
377 375
378 // The Browser object we are associated with. 376 // The Browser object we are associated with.
379 scoped_ptr<Browser> browser_; 377 scoped_ptr<Browser> browser_;
380 378
381 // Tool/Info bars that we are currently showing. Used for layout. 379 // Tool/Info bars that we are currently showing. Used for layout.
380 // active_bookmark_bar_ is either NULL, if the bookmark bar isn't showing,
381 // or is bookmark_bar_view_ if the bookmark bar is showing.
382 views::View* active_bookmark_bar_; 382 views::View* active_bookmark_bar_;
383 views::View* active_download_shelf_; 383 views::View* active_download_shelf_;
384 384
385 // The TabStrip. 385 // The TabStrip.
386 TabStrip* tabstrip_; 386 TabStrip* tabstrip_;
387 387
388 // The Toolbar containing the navigation buttons, menus and the address bar. 388 // The Toolbar containing the navigation buttons, menus and the address bar.
389 BrowserToolbarView* toolbar_; 389 BrowserToolbarView* toolbar_;
390 390
391 // The Bookmark Bar View for this window. Lazily created. 391 // The Bookmark Bar View for this window. Lazily created.
(...skipping 67 matching lines...) Expand 10 before | Expand all | Expand 10 after
459 459
460 // The timer used to update frames for the Loading Animation. 460 // The timer used to update frames for the Loading Animation.
461 base::RepeatingTimer<BrowserView> loading_animation_timer_; 461 base::RepeatingTimer<BrowserView> loading_animation_timer_;
462 462
463 // P13N stuff 463 // P13N stuff
464 #ifdef CHROME_PERSONALIZATION 464 #ifdef CHROME_PERSONALIZATION
465 FramePersonalization personalization_; 465 FramePersonalization personalization_;
466 bool personalization_enabled_; 466 bool personalization_enabled_;
467 #endif 467 #endif
468 468
469 // For debugging 7857.
470 bool is_removing_bookmark_bar_;
471
472 DISALLOW_COPY_AND_ASSIGN(BrowserView); 469 DISALLOW_COPY_AND_ASSIGN(BrowserView);
473 }; 470 };
474 471
475 #endif // CHROME_BROWSER_VIEWS_FRAME_BROWSER_VIEW_H_ 472 #endif // CHROME_BROWSER_VIEWS_FRAME_BROWSER_VIEW_H_
OLDNEW
« no previous file with comments | « chrome/browser/views/bookmark_bar_view.cc ('k') | chrome/browser/views/frame/browser_view.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698