Do not map virtual keycodes (VK_0 - VK_9) to characters when accelerators in ...

Do not map virtual keycodes (VK_0 - VK_9) to characters when accelerators in the UI. 
If we do that, the result is the layout-dependent. For instance, in fr-FR layout, we get 'a with grave' in place of '0' for Ctrl+0 (normal in Zoom menu). Besides, in Slovak lazout, we get 'e with accent'

This CL does not affect the actual behavior of accelerators (see issue 8043 for that), but only change the way they're displayed in the menu (even without this CL, ctrl-0 works fine in fr-FR AZERY layout and Slovak layout).

BUG=7444
TEST=Change your kbd layout to French Azery and see what key is shown next to 'Normal' in Page-Zoom menu. It should be 'Ctrl+0'. 


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=10476

[cpu_(ooo_6.6-7.5), 2009-02-25 23:23:07]

LGTM

[cpu_(ooo_6.6-7.5), 2009-02-26 01:45:56]

Actually... I am not sure anymore.

According to wikipedia (http://en.wikipedia.org/wiki/AZERTY)

"The digits 0 to 9 are on the same keys, but the shift key must be pressed to
type them. The non-shifted keys are used for accented lowercase characters."

So if we display "Ctrl + 0" a person that actually has an azerty keyboard will
be mislead. See screen shot:

http://en.wikipedia.org/wiki/File:AZERTY_keyboard_layout.JPG





On 2009/02/25 23:23:07, cpu wrote:
> LGTM

[jungshik at Google, 2009-02-26 19:34:55]

On 2009/02/26 01:45:56, cpu wrote:
> Actually... I am not sure anymore.
> 
> According to wikipedia (http://en.wikipedia.org/wiki/AZERTY)
> 
> "The digits 0 to 9 are on the same keys, but the shift key must be pressed to
> type them. The non-shifted keys are used for accented lowercase characters."

Ooops. I landed this morning not noticing your reply. 
 
> So if we display "Ctrl + 0" a person that actually has an azerty keyboard will
> be mislead. See screen shot:
> 
> http://en.wikipedia.org/wiki/File:AZERTY_keyboard_layout.JPG

Yes, that's what I meant in my comment (sorry if it's not clear. see also
http://crbug.com/8043 ). '+' in en-US QWERTY also needs 'shift' (unshifted, we
get '='), but for zoom in, we show 'ctrl++' rather than 'ctrl+=' because '+' has
an obvious intuitive meaning. I think we can say the same thing about 'a with
grave accent' vs '0'. 

Also, note that 'ctrl+0' also works with '0' in the number pad (even in fr
AZERY). 

Given all these, I think this change is better overall than otherwise.  What
would you say?

[cpu_(ooo_6.6-7.5), 2009-02-26 20:21:13]

I don't know what is the right answer :)

It seems your fix helps if the person changed the layout but did not actually
changed the physical keyboard. Mine seems to work better the other way.

I leave it up to you.


On 2009/02/26 19:34:55, Jungshik Shin wrote:
> On 2009/02/26 01:45:56, cpu wrote:
> > Actually... I am not sure anymore.
> > 
> > According to wikipedia (http://en.wikipedia.org/wiki/AZERTY)
> > 
> > "The digits 0 to 9 are on the same keys, but the shift key must be pressed
to
> > type them. The non-shifted keys are used for accented lowercase characters."
> 
> Ooops. I landed this morning not noticing your reply. 
>  
> > So if we display "Ctrl + 0" a person that actually has an azerty keyboard
will
> > be mislead. See screen shot:
> > 
> > http://en.wikipedia.org/wiki/File:AZERTY_keyboard_layout.JPG
> 
> Yes, that's what I meant in my comment (sorry if it's not clear. see also
> http://crbug.com/8043 ). '+' in en-US QWERTY also needs 'shift' (unshifted, we
> get '='), but for zoom in, we show 'ctrl++' rather than 'ctrl+=' because '+'
has
> an obvious intuitive meaning. I think we can say the same thing about 'a with
> grave accent' vs '0'. 
> 
> Also, note that 'ctrl+0' also works with '0' in the number pad (even in fr
> AZERY). 
> 
> Given all these, I think this change is better overall than otherwise.  What
> would you say?