Issue 2808082: AU: Remove instances of Omaha ID -- machine ID and user ID.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2808082: AU: Remove instances of Omaha ID -- machine ID and user ID. (Closed)

Created:
10 years, 4 months ago by petkov

Modified:
9 years, 7 months ago

Reviewers:
adlr

CC:
chromium-os-reviews_chromium.org

Base URL:
ssh://git@gitrw.chromium.org:9222/update_engine.git

Visibility:
Public.

Description

AU: Remove instances of Omaha ID -- machine ID and user ID. Also add a unit test to make sure we are not sending machineid or userid attributes. BUG=1439 TEST=unit tests, gmerged on device, checked for update, looked at logs

Patch Set 1 #

Patch Set 2 : fix typo in comment #

Patch Set 3 : comment typo fix #

Created: 10 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+20 lines, -133 lines)			Patch
M	omaha_request_action.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	omaha_request_action_unittest.cc	View	1 2	5 chunks	+17 lines, -9 lines	0 comments	Download
M	omaha_request_params.h	View		4 chunks	+2 lines, -11 lines	0 comments	Download
M	omaha_request_params.cc	View		3 chunks	+0 lines, -51 lines	0 comments	Download
M	omaha_request_params_unittest.cc	View		9 chunks	+0 lines, -61 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

LGTM

I like code reviews full of red :)

Expand Messages | Collapse Messages