Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Unified Diff: omaha_request_params.cc

Issue 2808082: AU: Remove instances of Omaha ID -- machine ID and user ID. (Closed) Base URL: ssh://git@gitrw.chromium.org:9222/update_engine.git
Patch Set: comment typo fix Created 10 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « omaha_request_params.h ('k') | omaha_request_params_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: omaha_request_params.cc
diff --git a/omaha_request_params.cc b/omaha_request_params.cc
index 33281ee39a5164a9424a3f5ef5aa1caf1819e02e..0789fbb06426485ae2d2f79e7d6c68741b63eb42 100644
--- a/omaha_request_params.cc
+++ b/omaha_request_params.cc
@@ -18,13 +18,6 @@
using std::map;
using std::string;
-namespace {
-const string OmahaIdPath() {
- return string(chromeos_update_engine::utils::kStatefulPartition) +
- "/etc/omaha_id";
-}
-} // namespace {}
-
namespace chromeos_update_engine {
const char* const OmahaRequestParams::kAppId(
@@ -36,8 +29,6 @@ const char* const OmahaRequestParams::kUpdateUrl(
bool OmahaRequestDeviceParams::Init(const std::string& in_app_version,
const std::string& in_update_url) {
- TEST_AND_RETURN_FALSE(GetMachineId(&machine_id));
- user_id = machine_id;
os_platform = OmahaRequestParams::kOsPlatform;
os_version = OmahaRequestParams::kOsVersion;
app_version = in_app_version.empty() ?
@@ -61,48 +52,6 @@ bool OmahaRequestDeviceParams::Init(const std::string& in_app_version,
return true;
}
-namespace {
-const size_t kGuidDataByteLength = 128 / 8;
-const string::size_type kGuidStringLength = 38;
-// Formats 16 bytes (128 bits) of data as a GUID:
-// "{XXXXXXXX-XXXX-XXXX-XXXX-XXXXXXXXXXXX}" where X is a hex digit
-string GuidFromData(const unsigned char data[kGuidDataByteLength]) {
- return StringPrintf(
- "{%02X%02X%02X%02X-%02X%02X-%02X%02X-%02X%02X-%02X%02X%02X%02X%02X%02X}",
- data[0], data[1], data[2], data[3], data[4], data[5], data[6], data[7],
- data[8], data[9], data[10], data[11], data[12], data[13], data[14],
- data[15]);
-}
-}
-
-// Returns true on success.
-bool OmahaRequestDeviceParams::GetMachineId(std::string* out_id) const {
- // Checks if we have an existing Machine ID.
- const string omaha_id_path = root_ + OmahaIdPath();
-
- if (utils::ReadFileToString(omaha_id_path, out_id) &&
- out_id->size() == kGuidStringLength) {
- return true;
- }
-
- // Creates a new ID.
- int rand_fd = open("/dev/urandom", O_RDONLY, 0);
- TEST_AND_RETURN_FALSE_ERRNO(rand_fd >= 0);
- ScopedFdCloser rand_fd_closer(&rand_fd);
- unsigned char buf[kGuidDataByteLength];
- size_t bytes_read = 0;
- while (bytes_read < sizeof(buf)) {
- ssize_t rc = read(rand_fd, buf + bytes_read, sizeof(buf) - bytes_read);
- TEST_AND_RETURN_FALSE_ERRNO(rc > 0);
- bytes_read += rc;
- }
- string guid = GuidFromData(buf);
- TEST_AND_RETURN_FALSE(
- utils::WriteFile(omaha_id_path.c_str(), guid.data(), guid.size()));
- *out_id = guid;
- return true;
-}
-
string OmahaRequestDeviceParams::GetLsbValue(
const string& key, const string& default_value) const {
string files[] = {string(utils::kStatefulPartition) + "/etc/lsb-release",
« no previous file with comments | « omaha_request_params.h ('k') | omaha_request_params_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698