Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2687)

Unified Diff: omaha_request_params.h

Issue 2808082: AU: Remove instances of Omaha ID -- machine ID and user ID. (Closed) Base URL: ssh://git@gitrw.chromium.org:9222/update_engine.git
Patch Set: comment typo fix Created 10 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « omaha_request_action_unittest.cc ('k') | omaha_request_params.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: omaha_request_params.h
diff --git a/omaha_request_params.h b/omaha_request_params.h
index 16def259192b276869c57153c5ffab5c3d82e494..9c372584d5a176fb966f344704ef5d547a547e88 100644
--- a/omaha_request_params.h
+++ b/omaha_request_params.h
@@ -19,9 +19,7 @@ namespace chromeos_update_engine {
struct OmahaRequestParams {
OmahaRequestParams()
: os_platform(kOsPlatform), os_version(kOsVersion), app_id(kAppId) {}
- OmahaRequestParams(const std::string& in_machine_id,
- const std::string& in_user_id,
- const std::string& in_os_platform,
+ OmahaRequestParams(const std::string& in_os_platform,
const std::string& in_os_version,
const std::string& in_os_sp,
const std::string& in_os_board,
@@ -31,9 +29,7 @@ struct OmahaRequestParams {
const std::string& in_app_track,
const bool in_delta_okay,
const std::string& in_update_url)
- : machine_id(in_machine_id),
- user_id(in_user_id),
- os_platform(in_os_platform),
+ : os_platform(in_os_platform),
os_version(in_os_version),
os_sp(in_os_sp),
os_board(in_os_board),
@@ -44,8 +40,6 @@ struct OmahaRequestParams {
delta_okay(in_delta_okay),
update_url(in_update_url) {}
- std::string machine_id;
- std::string user_id;
std::string os_platform;
std::string os_version;
std::string os_sp;
@@ -79,9 +73,6 @@ class OmahaRequestDeviceParams : public OmahaRequestParams {
void set_root(const std::string& root) { root_ = root; }
private:
- // Gets a machine-local ID (for now, first MAC address we find).
- bool GetMachineId(std::string* out_id) const;
-
// Fetches the value for a given key from
// /mnt/stateful_partition/etc/lsb-release if possible. Failing that,
// it looks for the key in /etc/lsb-release.
« no previous file with comments | « omaha_request_action_unittest.cc ('k') | omaha_request_params.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698