Issue 2808005: Fix windows build

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2808005: Fix windows build (Closed)

Created:
10 years, 6 months ago by Evan Stade

Modified:
9 years, 6 months ago

Reviewers:
michaeln

CC:
chromium-reviews, ben+cc_chromium.org

Base URL:
http://src.chromium.org/git/chromium.git

Visibility:
Public.

Description

Fix windows build BUG=none TEST=compile TBR=michaeln Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=49825

Patch Set 2 : style #

Total comments: 1

Created: 10 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -3 lines)			Patch
	M	chrome/browser/upgrade_detector.cc	View	1	1 chunk	+3 lines, -3 lines	1 comment	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

michaeln

http://codereview.chromium.org/2808005/diff/2001/3001 File chrome/browser/upgrade_detector.cc (right): http://codereview.chromium.org/2808005/diff/2001/3001#newcode81 chrome/browser/upgrade_detector.cc:81: scoped_ptr<Version> installed_version(InstallUtil::GetChromeVersion(false)); We weren't calling 'detete' on this object ...

10 years, 6 months ago (2010-06-15 20:01:47 UTC) #1