Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1674)

Unified Diff: chrome/browser/upgrade_detector.cc

Issue 2808005: Fix windows build (Closed) Base URL: http://src.chromium.org/git/chromium.git
Patch Set: style Created 10 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/upgrade_detector.cc
diff --git a/chrome/browser/upgrade_detector.cc b/chrome/browser/upgrade_detector.cc
index 49db0ce83e1b7a0668fc20826d3d92e8ad191e58..88258891936a6637d15e65a57b6d373a49127003 100644
--- a/chrome/browser/upgrade_detector.cc
+++ b/chrome/browser/upgrade_detector.cc
@@ -78,10 +78,10 @@ class DetectUpgradeTask : public Task {
// Get the version of the currently *installed* instance of Chrome,
// which might be newer than the *running* instance if we have been
// upgraded in the background.
- Version* installed_version = InstallUtil::GetChromeVersion(false);
- if (!installed_version) {
+ scoped_ptr<Version> installed_version(InstallUtil::GetChromeVersion(false));
michaeln 2010/06/15 20:01:47 We weren't calling 'detete' on this object before.
+ if (!installed_version.get()) {
// User level Chrome is not installed, check system level.
- installed_version = InstallUtil::GetChromeVersion(true);
+ installed_version.reset(InstallUtil::GetChromeVersion(true));
}
#elif defined(OS_LINUX)
CommandLine command_line(*CommandLine::ForCurrentProcess());
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698