Fix windows build

chrome/browser/upgrade_detector.cc

 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/upgrade_detector.h"
 
 #include "base/command_line.h"
 #include "base/file_version_info.h"
 #include "base/scoped_ptr.h"
 #include "base/time.h"
@@ skipping 60 matching lines @@
   virtual void Run() {
     DCHECK(ChromeThread::CurrentlyOn(kDetectUpgradeTaskID));
 
 #if defined(OS_WIN) || defined(OS_LINUX)
     using installer::Version;
 
 #if defined(OS_WIN)
     // Get the version of the currently *installed* instance of Chrome,
     // which might be newer than the *running* instance if we have been
     // upgraded in the background.
-    Version* installed_version = InstallUtil::GetChromeVersion(false);
-    if (!installed_version) {
+    scoped_ptr<Version> installed_version(InstallUtil::GetChromeVersion(false));

[michaeln, 2010/06/15 20:01:47]

We weren't calling 'detete' on this object before... now we are... is that OK?

+    if (!installed_version.get()) {
       // User level Chrome is not installed, check system level.
-      installed_version = InstallUtil::GetChromeVersion(true);
+      installed_version.reset(InstallUtil::GetChromeVersion(true));
     }
 #elif defined(OS_LINUX)
     CommandLine command_line(*CommandLine::ForCurrentProcess());
     command_line.AppendSwitch(switches::kProductVersion);
     std::string reply;
     if (!base::GetAppOutput(command_line, &reply)) {
       DLOG(ERROR) << "Failed to get current file version";
       return;
     }
 
@@ skipping 82 matching lines @@
 }
 
 void UpgradeDetector::NotifyOnUpgrade() {
   notify_upgrade_ = true;
 
   NotificationService::current()->Notify(
       NotificationType::UPGRADE_RECOMMENDED,
       Source<UpgradeDetector>(this),
       NotificationService::NoDetails());
 }