Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4477)

Unified Diff: chrome/browser/cocoa/location_bar/bubble_decoration.mm

Issue 2806098: [Mac] Un-tweak omnibox height and spacing and font. (Closed) Base URL: git://codf21.jail/chromium.git
Patch Set: Peter suggested bumping RHS spacing. Created 10 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/cocoa/location_bar/autocomplete_text_field_cell.mm ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/cocoa/location_bar/bubble_decoration.mm
diff --git a/chrome/browser/cocoa/location_bar/bubble_decoration.mm b/chrome/browser/cocoa/location_bar/bubble_decoration.mm
index 60c5da2e6e70ad6dfd1bd28aaf03ae0e603aa2fa..79570a5e7349d354f2b7905ada0417dedd597696 100644
--- a/chrome/browser/cocoa/location_bar/bubble_decoration.mm
+++ b/chrome/browser/cocoa/location_bar/bubble_decoration.mm
@@ -19,7 +19,7 @@ const CGFloat kBubblePadding = 3.0;
// to differ from the location icon's. Indeed, that's how the views
// implementation handles the problem. This draws the bubble edge a
// little bit further left, which is easier but no less hacky.
-const CGFloat kLeftSideOverdraw = 1.0;
+const CGFloat kLeftSideOverdraw = 2.0;
// Omnibox corner radius is |4.0|, this needs to look tight WRT that.
const CGFloat kBubbleCornerRadius = 2.0;
@@ -31,9 +31,6 @@ const CGFloat kBubbleCornerRadius = 2.0;
// reflect the single pixel space w/in that.
const CGFloat kBubbleYInset = 4.0;
-// How far to inset the text from the edge of the bubble.
-const CGFloat kTextYInset = 1.0;
-
} // namespace
BubbleDecoration::BubbleDecoration(NSFont* font) {
@@ -129,7 +126,6 @@ void BubbleDecoration::DrawInFrame(NSRect frame, NSView* control_view) {
NSRect textRect = decorationFrame;
textRect.origin.x = NSMaxX(imageRect);
textRect.size.width = NSMaxX(decorationFrame) - NSMinX(textRect);
- textRect.origin.y += kTextYInset;
[label_ drawInRect:textRect withAttributes:attributes_];
}
}
« no previous file with comments | « chrome/browser/cocoa/location_bar/autocomplete_text_field_cell.mm ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698